Skip to content

[battery_manager] Add required DDE selection #9741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

skarya22
Copy link
Contributor

@skarya22 skarya22 commented Apr 7, 2025

Brief summary of changes

  • Updated the New Test form in the Battery Manager to better showcase that selecting a DDE option is required.
  • It defaults to No, and includes a red * that the field is required.
image

Testing instructions (if applicable)

  1. Try to create a new Test without modifying the DDE selection and confirm it works
  2. Try to create a new Test with DDE == 'Yes' and confirm it works

Link(s) to related issue(s)

@driusan
Copy link
Collaborator

driusan commented Apr 11, 2025

@GeorgeMurad can you review/test?

@driusan driusan requested a review from GeorgeMurad April 11, 2025 19:02
Copy link
Contributor

@GeorgeMurad GeorgeMurad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, It works for both Yes and No options.

@driusan driusan merged commit a9df2b1 into aces:main Apr 11, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants