Open Source C++ api #3083
Open
Open Source C++ api #3083
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR adds open source C++ API support by introducing several third-party libraries and supporting files to the codebase, specifically libtiff (TIFF image library) and boost json functionality.
Key changes:
- Added comprehensive libtiff implementation including multiple compression codecs (JPEG, JBIG, LERC, LogLuv)
- Added supporting utilities (hash set, error handling, flush operations, extension support)
- Added boost json library integration as header-only
Reviewed changes
Copilot reviewed 34 out of 735 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| cpp/3rd_party/libtiff/tif_luv.c | Implements LogLuv compression for high dynamic range images |
| cpp/3rd_party/libtiff/tif_lerc.c | Implements LERC compression codec |
| cpp/3rd_party/libtiff/tif_jpeg_12.c | Implements 12-bit JPEG support |
| cpp/3rd_party/libtiff/tif_jpeg.c | Implements JPEG compression/decompression |
| cpp/3rd_party/libtiff/tif_jbig.c | Implements JBIG compression |
| cpp/3rd_party/libtiff/tif_hash_set.h | Defines hash set data structure interface |
| cpp/3rd_party/libtiff/tif_hash_set.c | Implements hash set functionality |
| cpp/3rd_party/libtiff/tif_flush.c | Implements TIFF flush operations |
| cpp/3rd_party/libtiff/tif_extension.c | Implements tag extension support |
| cpp/3rd_party/libtiff/tif_error.c | Implements error handling |
| cpp/3rd_party/libtiff/tif_dumpmode.c | Implements null compression mode |
| cpp/3rd_party/libtiff/snprintf.c | Provides snprintf workaround for Visual Studio |
| cpp/3rd_party/libtiff/libport.h | Declares portability functions |
| cpp/3rd_party/json/src.cpp | Includes boost json as single compilation unit |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| if (sp->h_sampling == 0 || sp->v_sampling == 0) | ||
| { | ||
| TIFFErrorExtR(tif, module, | ||
| "Invalig horizontal/vertical sampling value"); |
There was a problem hiding this comment.
Corrected spelling of 'Invalig' to 'Invalid'.
Suggested change
| "Invalig horizontal/vertical sampling value"); | |
| "Invalid horizontal/vertical sampling value"); |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 🚀 Pull Request
Impact
Description
Things to be aware of
Things to worry about
Additional Context