Skip to content

Upgrade the CI process to validate with prettier #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Upgrade the CI process to validate with prettier #78

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 33 additions & 16 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,24 +1,43 @@
version: 2

jobs:
atoti_query:
docker:
- image: cimg/node:18.13.0
commands:
install_atoti_query_deps:
steps:
- checkout
- restore_cache:
keys:
- deps-atoti-{{ checksum "atoti-query-analyser/package.json" }}
- run:
name: Install dependencies
command: yarn install --cwd atoti-query-analyser
- run:
name: Build application
command: yarn --cwd atoti-query-analyser build
- save_cache:
key: deps-atoti-{{ checksum "atoti-query-analyser/package.json" }}
paths:
- atoti-query-analyser/node_modules
when: on_success

jobs:
check_atoti_query:
docker:
- image: cimg/node:18.13.0
steps:
- checkout
- install_atoti_query_deps
- run:
name: Check formatting
command: yarn --cwd atoti-query-analyser format-prettier --check
- run:
# Build in the CI as it checks more errors
name: Build application
command: yarn --cwd atoti-query-analyser build
build_atoti_query:
docker:
- image: cimg/node:18.13.0
steps:
- checkout
- install_atoti_query_deps
- run:
name: Build application
command: yarn --cwd atoti-query-analyser build
- run:
name: Move to workspace
command: |
Expand Down Expand Up @@ -68,17 +87,15 @@ jobs:

workflows:
version: 2
test:
jobs:
- check_atoti_query
build:
jobs:
- atoti_query:
- build_atoti_query:
filters:
branches:
ignore:
- master
- /wip-*/
only: develop
- deploy_to_master:
requires:
- atoti_query
filters:
branches:
only: develop
- build_atoti_query