Add alignment workflow for the OpenDataDetector #4910
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove unnecessary exception handling in Alignment.ipp - Fix alignment derivative calculations in Surface.cpp - Add alignment-related Python bindings and scripts - Update alignment algorithm interfaces
github-actions
bot
added
Component - Core
Contributor
|
Hi @Zequn-SUN - there are small conflicts due to the change of the python directories, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a complete detector alignment workflow for the OpenDataDetector (ODD), implementing a full pipeline from simulation with the nominal geometry, alignment with the misaligned geometry, to reconstructions with the nominal, misaligned, and aligned geometry, respectively. The script implementing the complete workflow is
Examples/Scripts/Python/alignment_odd.pyThis script needs a json file containing the transform information of each ODD sensor. This json file can be found here
https://cernbox.cern.ch/files/spaces/eos/user/z/zesun/odd_transforms.json
For detailed documentation and usage instructions, please refer to:
https://docs.google.com/document/d/1FHyWZoeHhygSMH9F7IPQbE7_Dx9tlPPXQhbNMYYZLJ8/edit?usp=sharing
--- END COMMIT MESSAGE ---
Any further description goes here, @-mentions are ok here!
feat,fix,refactor,docs,choreandbuildtypes.