fix: adapt Mat_map_surface_plot.C to read sur_type from geometry-map.json #4931
+64
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
andiwand
reviewed
Jan 5, 2026
Contributor
andiwand
left a comment
andiwand
left a comment
There was a problem hiding this comment.
I am not familiar with these scripts and there purpose - do you think you could have a look @asalzburger ?
Member
|
Maybe we should cover this in CI? |
veprbl
force-pushed
the
pr/sur_type_from_json
branch
from
ceb0feb to
83aa0a9
Compare
Contributor
Author
We do that at ePIC:
But the full statistics map regeneration takes a while. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sur_type and sur_range_min/max were removed in #4353, so these macros don't work anymore. This adapts the macros to access the same information from the JSON files.
--- END COMMIT MESSAGE ---
I think, at ePIC we are still interested in surface material maps on up to date Acts.
This is alternative to #4929.
I'm not yet sure about type==4 case yet, it's defunct now, and I don't have a handy test case.
Any further description goes here, @-mentions are ok here!
feat,fix,refactor,docs,choreandbuildtypes.