feat: add install‑time git hash patching to ActsConfig.cmake #4932
+52
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add logic in `cmake/ActsCreatePackageConfig.cmake` that, when building from a git repository, injects the current commit hash (and short hash) into the installed `ActsConfig.cmake`. The patch also marks dirty working trees with a “-dirty” suffix. This ensures the installed package reports an accurate source revision without requiring a separate build step.
github-actions
bot
added
the
Infrastructure
andiwand
approved these changes
Jan 5, 2026
Contributor
|
Collaborator
acts-project-service
added
the
Breaks Athena build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add logic in
cmake/ActsCreatePackageConfig.cmakethat, when building from a git repository, injects the current commit hash (and short hash) into the installedActsConfig.cmake. The patch also marks dirty working trees with a “-dirty” suffix. This ensures the installed package reports an accurate source revision without requiring a separate build step.