Skip to content

Avoid several copies into pageable CUDA memory #1223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
stephenswat wants to merge 1 commit into from
Closed

Avoid several copies into pageable CUDA memory #1223

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion device/cuda/src/finding/combinatorial_kalman_filter.cuh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,8 @@ combinatorial_kalman_filter(
* Measurement Operations
*****************************************************************/

const auto n_measurements = copy.get_size(measurements_view);
const auto n_measurements =
get_size(measurements_view, size_staging_ptr.get(), stream);

// Access the detector view as a detector object
detector_t device_det(det);
Expand Down
5 changes: 4 additions & 1 deletion device/cuda/src/seeding/seed_finding.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@

// Local include(s).
#include "../utils/cuda_error_handling.hpp"
#include "../utils/get_size.hpp"
#include "../utils/global_index.hpp"
#include "../utils/utils.hpp"
#include "traccc/cuda/seeding/details/seed_finding.hpp"
Expand Down Expand Up @@ -183,7 +184,9 @@ edm::seed_collection::buffer seed_finding::operator()(
vecmem::data::vector_buffer sp_grid_prefix_sum_buff =
make_prefix_sum_buff(grid_sizes, m_copy, m_mr, m_stream);

const auto num_spacepoints = m_copy.get_size(sp_grid_prefix_sum_buff);
const auto num_spacepoints =
get_size(sp_grid_prefix_sum_buff, size_staging_ptr.get(), stream);

if (num_spacepoints == 0) {
return {0, m_mr.main};
}
Expand Down
3 changes: 2 additions & 1 deletion device/cuda/src/seeding/spacepoint_formation_algorithm.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,8 @@ edm::spacepoint_collection::buffer spacepoint_formation_algorithm::operator()(
vecmem::make_unique_alloc<unsigned int>(*(m_mr.host));

// Get the number of measurements.
const auto num_measurements = m_copy.get().get_size(measurements_view);
const auto num_measurements =
get_size(measurements_view, size_staging_ptr.get(), stream);

// Create the result buffer.
edm::spacepoint_collection::buffer spacepoints(
Expand Down
Loading