First round of MBF cleanup #1224
Open
+84
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit is the first round of clean-up and improvements to be made to the MBF code, fixing some obvious bugs.
stephenswat
added
bug
|
krasznaa
approved these changes
Dec 10, 2025
| * finding, we need some space to store the intermediate Jacobians | ||
| * and parameters. Allocate that space here. | ||
| */ | ||
| if (false && config.run_mbf_smoother) { |
Member
There was a problem hiding this comment.
Does the code fail to run? This is a pretty good way of keeping it inactive for the moment, but what's the need? Is it that the code is not tested at the moment?
Member
|
Though I only saw the remaining failure after my comments. 😦 Do you understand what's still going wrong with the SYCL CKF tests? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is the first round of clean-up and improvements to be made to the MBF code, fixing some obvious bugs.