Update ACTS to version 46.5.0 and use its detray#1327
Open
stephenswat wants to merge 1 commit into
Open
Conversation
niermann999
approved these changes
May 13, 2026
f9f8115 to
05593ea
Compare
niermann999
approved these changes
May 13, 2026
05593ea to
6f8eee6
Compare
Member
Author
|
I believe this is currently broken by this change to short-circuiting logic between: and |
krasznaa
requested changes
May 14, 2026
Member
krasznaa
left a comment
There was a problem hiding this comment.
I see 2 options to move forward:
- We first make some changes in Acts. Currently it is just way too hostile towards the setup that we would need from it.
- We keep the fundamental setup in this repository as it's always been.
- We keep
extern/actsbuilding just Acts; - We make
extern/detraydownload the Acts TGZ, and build Detray out of that. (Using aSOURCE_SUBDIRargument to the existingFetchContentcall. So that it would pick up just Detray out of the Acts source tree.)
- We keep
Clearly N.1 is the better choice. But it's also what will take longer.
Member
Author
Explain to me how this is any better than the current approach. |
This was referenced May 14, 2026
Contributor
|
Should be fixed here https://github.com/acts-project/acts/pull/5452/changes |
This commit updates our ACTS dependency to version 46.5.0. It also removes our own external detray mechanisms and relies almost entirely on ACTS to provide detray. Until ACTS directly exposes the detray targets, we still need to FetchContent the detray content from the ACTS repository. Also automatically adds the ITk detector metadata if it is not provided.
6f8eee6 to
55abee5
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



This commit updates our ACTS dependency to version 46.5.0. It also removes our own external detray mechanisms and relies almost entirely on ACTS to provide detray. Until ACTS directly exposes the detray targets, we still need to FetchContent the detray content from the ACTS repository. Also automatically adds the ITk detector metadata if it is not provided.