feat: colored negative account balances in sidebar #4681
Conversation
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Bundle Stats — desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged
|
Bundle Stats — loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
|
/update-vrt |
WalkthroughThe pull request updates the account component in the desktop client to enhance the rendering of account balances. The changes include importing a helper function from the budget utility module that determines the full styling for amounts based on theme colors. The Assessment against linked issues
Possibly related PRs
Suggested labels
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (4)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
👋 Heya! Thanks for opening this PR. I'll share my thoughts and then let other maintainers weigh in. Personally, I do not like having rainbow colors in the side navigation. We try to make Actual But the addition of a new setting would solve this, right? Kind of.. but it violates another principle we have - we do not want to have a long list of settings - one for each and every little ui quirk/edge case that folks might have. Actual has some level of flexibility, but it's not a complete sandbox. Thus - adding a setting for the colors in the side nav is a hard pass. So what can we do here? My recommendation would be to apply a custom css stylesheet for these colors. There's plenty of browser extensions that allow this. But I would not be in favour of mainlaining this PR. |
|
Im not a fan of the green, but I would be ok with negative is red since that is already a thing other places. |
|
Thanks for the feedback! I understand the concern about maintaining a clean design and avoiding excessive settings. However, I think that highlighting negative balances specifically isn't just a minor UI tweak - it has real value in making it easier to quickly identify accounts with a negative balance, especially when users have a long list of accounts. Since red is already used elsewhere for negative balances, including the mobile view for the accounts list, applying it in the sidebar maintains consistency rather than introducing something new. Unlike green for positive balances, which I understand could be seen as unnecessary, red for negatives aligns with existing design choices and improves usability. So we could have something like this:
|
in the sidebar, color negative account balances in red
tostasmistas
force-pushed
the
feat/accounts-balance-color
branch
from
1d6e5e1 to
d0f369b
Compare
tostasmistas
changed the title
|
/update-vrt |
|
I don't mind the red in negatives, but I don't like having the green.
|
|
I have updated the PR to remove the setting, and now by default only the negative balances are colored in red. |
|
Thanks for removing the setting toggle and the green color indicator. I'm still on the fence about the red color for account balances. Negative balance is not always "bad". For example in the demo budget mortgage is a negative amount. It's not necessarily "bad" and thus in my opinion - should not have a special color highlight. I can see similar cases with other off-budget accounts too. That being said - only adding the red color highlight is a much less controversial change and I won't stand in the way of merging it if the other maintainers are happy with it. |
|
Occasionally people ask for accounting format numbers. Maybe at some point we could add that in as an option that would leave the numbers all the same color. |
This was my original suggestion when this came up in discord as well. |
|
@youngcw @Teprifer just so I get this right - are you recommending adding a configurable setting for balance colors? Or is it something else? For a new setting I have a very strong opinion explained in the comment above. |
|
I was thinking red for negative accounts would be for everyone, then potentially an option to choose if you have standard negative numbers or accounting style negative numbers. |
Something else, either separate, or in addition to. I actually thought we had an existing feature request for this but I couldn't find one, so have now created one: #4721 |
This PR resolves #4673.
It adds a setting, that when enabled, colors account balances in the sidebar based on their value: positives balances are displayed in green and negative balances are displayed in red.
and privacy filter