set radio idle before reading temperature #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR will add a few bytes to the adafruit_rfm69 library (I have not checked the actual size) and may impact the CP builds for the feather M0 RFM69. I suppose this could also be "fixed" with a documentation note that instructs the user to always call .idle() before reading the .temperature property. This will require the user code to have the extra call. Adding it as in the PR is "cleaner". |
tannewt
approved these changes
Oct 1, 2025
adafruit-adabot
pushed a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Oct 14, 2025
Updating https://github.com/adafruit/Adafruit_CircuitPython_EPD to 2.17.0 from 2.16.0: > Merge pull request adafruit/Adafruit_CircuitPython_EPD#100 from adafruit/jd79667 > Merge pull request adafruit/Adafruit_CircuitPython_EPD#99 from adafruit/uc8253 Updating https://github.com/adafruit/Adafruit_CircuitPython_RFM69 to 2.1.26 from 2.1.25: > Merge pull request adafruit/Adafruit_CircuitPython_RFM69#57 from jerryneedell/jerryn_temperature Updating https://github.com/adafruit/Adafruit_CircuitPython_SPA06_003 to 1.0.1 from 1.0.0: > remove debugging print. move float() cast to coeff reading instead of equations. Updating https://github.com/adafruit/Adafruit_CircuitPython_Qualia to 2.1.2 from 2.1.1: > Merge pull request adafruit/Adafruit_CircuitPython_Qualia#11 from makermelissa/main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #56
tested on feather rp2040 rfm69 (CP 10.0.0-rc.0) and in Raspberry Pi 5 with RFM69 bonnet.