add SPI support and example #1
Conversation
|
Note: this should bump to 2.0.0 when released because the class name change from |
adafruit_spa06_003.py
Outdated
| i2c: I2C = None, | ||
| address: int = SPA06_003_DEFAULT_ADDR, | ||
| spi: SPI = None, | ||
| cs: DigitalInOut = None, |
There was a problem hiding this comment.
I feel like this should take in the device now. As-is it's this weird if i2c then do these two kwargs, otherwise do these two others. The other option would be separate class method constructors but I think providing device is probably clearest. Then internally, you can check the type and create the correct accessor.
There was a problem hiding this comment.
I updated this to take the bus device object in the constructor with the latest commit. I am thinking some separate class methods would be pretty convenient though. With this current version the user code must concern itself with I2C Address, and SPI polarity/phase. Before, these had default values provided by the driver so user didn't have to provide them.
There was a problem hiding this comment.
Maybe we should have a "device" kwarg that can be an I2C, I2CDevice (for non default address) or SPIDevice. What do you think? I agree the example is a bit weird now needing to import the default address.
Polarity and phase could be handled by a configure method or with mutable properties on SPIDevice. Chip select makes sense to have the user code worry about.
There was a problem hiding this comment.
I think that approach sounds good. I started the changes without realizing the SPIDevice doesn't yet allow changing phase, polarity, or baudrate. I'll try to make those mutable in the core.
There was a problem hiding this comment.
I opened adafruit/circuitpython#10658 making phase and polarity mutable on SPIDevice, and use those new properties in the latest commit here to configure the SPIDevice internally within the driver instead of relying on user code.
The latest commit also allows I2C bus in addition to I2CDevice as the argument which will cause it to initialize with the default I2C address.
|
The latest commit has |
| time.sleep(0.01) | ||
|
|
||
|
|
||
| class SPA06_003_I2C(SPA06_003): |
There was a problem hiding this comment.
Do we still need a class? Or can this be a function?
Also, please use the warnings module. I believe most CP builds will have it.
| except ValueError: | ||
| raise ValueError(f"No SPI device found.") |
There was a problem hiding this comment.
Why catch this? Isn't it what gets thrown anyway?
2 participants
This relies on the changes from: adafruit/Adafruit_CircuitPython_Register#59 So that should be merged before this is.
Adds SPI support by using new functionality pending addition to adafruit_register
This should be a major version bump if merged because the class name changed from the bus specific SPA06_003_I2C to the now generic SPA06_003.
Tested successfully with both SPI and I2C on
Adafruit CircuitPython 10.0.0-beta.3 on 2025-08-29; Adafruit Feather RP2040 with rp2040