Import date/time modules once in C extension #553
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamchainz
force-pushed
the
import_once
branch
from
56eacb8 to
e63b086
Compare
adamchainz
changed the title
adamchainz
added a commit
that referenced
this pull request
Aug 19, 2025
Following #553, move all the other imports in the C extenion to only be done once: * datetime class * datetime.datetime.now * datetime.datetime.utcnow * time.clock_gettime * time.clock_gettime_ns * time.gmtime * time.localtime * time.monotonic * time.monotonic_ns * time.strftime * time.time * time.time_ns
adamchainz
added a commit
that referenced
this pull request
Aug 19, 2025
Following #553, move all the other imports in the C extenion to only be done once: * datetime class * datetime.datetime.now * datetime.datetime.utcnow * time.clock_gettime * time.clock_gettime_ns * time.gmtime * time.localtime * time.monotonic * time.monotonic_ns * time.strftime * time.time * time.time_ns Fixes #531 .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying an alternative approach to #531.