Adds freezer to the migration script #562
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kingbuzzman
force-pushed
the
dev/freezer-cli-migrate
branch
from
569bc85 to
b895333
Compare
adamchainz
requested changes
Aug 26, 2025
Comment on lines
+120
to
+124
| # Phase 1: Collect all information | ||
| state = collect_migration_state(ast_obj) | ||
|
|
||
| # Phase 2: Generate callbacks based on collected state | ||
| callbacks = generate_callbacks(state) |
There was a problem hiding this comment.
I don't like this two-pass approach, it decouples things too much
it's better to have the token-rewriting functions read bits of state as necessary
see examples in django-upgrade such as
There was a problem hiding this comment.
Issue is that i needed to see if there is both freezegun and freezer -- and if there is, just go with freezer. I'll rethink the strategy. thanks for the feedback
Comment on lines
+25
to
+27
| @dataclass | ||
| class State: | ||
| """State collected during preprocessing to guide transformations.""" |
There was a problem hiding this comment.
please don't use a giant dataclass of state, I would prefer some local variables, which may use mini classes to collect several fields. Use plain classes, not dataclasses, for speed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.