Fix: Route loading, serveSchema bugs, and handler name migration#86
Merged
Fix: Route loading, serveSchema bugs, and handler name migration#86
Conversation
Co-authored-by: taylortom <1059083+taylortom@users.noreply.github.com>
…efs #85) setValues() was missing the loadRouteConfig call so routes.json was never loaded. Also converts serveSchema from factory to standard handler, renames handler strings to match method names, adds API metadata from the removed apidefs.js, and adds adapt-authoring-server peer dependency.
#85) The override was using res.sendError() instead of next() for error propagation, and returning the raw schema object instead of schema.built. Both now match the base class convention in AbstractApiModule.
Meta has been moved to routes.json.
|
🎉 This PR is included in version 1.5.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up fixes to #85 which moved route definitions to
routes.json.loadRouteConfigcall tosetValues()so routes are actually loadedserveSchemafrom factory to standard handlerserveSchemaerror handling: usesnext()instead ofres.sendError(), returnsschema.built, usesNO_SCHEMA_DEFerrordefault,query) to method names (requestHandler,queryHandler) to match the factory-to-standard-method conversion in adapt-authoring-apiapidefs.jstoroutes.jsonadapt-authoring-serverpeer dependencyFix
setValues()now callsloadRouteConfigsoroutes.jsonis actually loadedserveSchemausesnext()for error propagation,NO_SCHEMA_DEFerror, and returnsschema.builtUpdate
routes.jsonTest plan
npm test— all 44 ContentPluginModule tests passnpm run dev, verify:POST /api/contentplugins/install)GET /api/contentplugins/schema)🤖 Generated with Claude Code