Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add inline to objects in dotenv.h to prevent multiple definition erro… #16

Merged
merged 2 commits into from
Jul 30, 2020

Conversation

gwint
Copy link

@gwint gwint commented Jul 27, 2020

…rs during linking

Copy link
Owner

@adeharo9 adeharo9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely right, didn't think about it at the time.

However, this makes the code C++17-specific, so please update the corresponding CMAKE_CXX_STANDARD variable on the CMakeLists.txt file from 11 to 17 and add the commit to the pull request before I merge.

@adeharo9 adeharo9 dismissed their stale review July 29, 2020 10:55

Wrong place to request changes

@adeharo9
Copy link
Owner

Absolutely right, didn't think about it at the time.

However, this makes the code C++17-specific, so please update the corresponding CMAKE_CXX_STANDARD variable on the CMakeLists.txt file from 11 to 17 and add the commit to the pull request before I merge.

@adeharo9 adeharo9 merged commit 453d2a5 into adeharo9:master Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants