-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: goroutine leak for tasker #38
fix: goroutine leak for tasker #38
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #38 +/- ##
==========================================
- Coverage 93.72% 93.65% -0.08%
==========================================
Files 9 9
Lines 685 693 +8
==========================================
+ Hits 642 649 +7
- Misses 25 26 +1
Partials 18 18 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks again. before we merge, i would have to ask issue reproduction steps.
also are we sure it won't break anything?
btw ctrl+c handling is fixed in #41, does that help the issue this PR relates to? |
Signed-off-by: rfyiamcool <[email protected]>
094d1c2
to
bc068a5
Compare
ok i see, right now my concern is if the new changes here would break things or not |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging it for now but cant create a release as it has a concern unaddressed
summary
goroutine leak.
maybe happen cases:
ctxdone
goroutine don't exit.