Add external images processing functionality#935
Open
gazal2708 wants to merge 11 commits intoadobe:mainfrom
Open
Add external images processing functionality#935gazal2708 wants to merge 11 commits intoadobe:mainfrom
gazal2708 wants to merge 11 commits intoadobe:mainfrom
Conversation
- Add processExternalImages step to extract width/height from URL params - Set hardcoded width=750 and quality=65 for external images - Add width/height attributes to processed images - Add comprehensive test coverage for external images processing - Include test fixtures for external images markdown and expected HTML
- Replace generic external URLs with realistic Adobe delivery service URLs - Use format: https://delivery-p12345-e67890.adobeaemcloud.com/adobe/assets/urn:aaid:aem:... - Remove unnecessary 'other=param' from test URLs - Align test format with existing codebase patterns
- Add external image test cases to images.md and images.html - Include scenarios: with width/height, with only width, without width/height - Use Adobe delivery URLs for realistic testing - Remove separate external-images test files - Update rendering.test.js to use images test instead of external-images - All tests passing with 95.23% coverage for process-external-images.js
- Add EXTERNAL_IMAGE_WIDTH and EXTERNAL_IMAGE_QUALITY constants - Replace hardcoded '750' and '65' values with constants - Follow same pattern as BREAK_POINTS in create-pictures.js - Improve code maintainability and consistency
mhaack
reviewed
Sep 11, 2025
actinium15
reviewed
Sep 12, 2025
- Remove hardcoded quality, preserve existing quality in URLs - Always process external images, add attributes only if width/height present - Add configurable externalImageUrlPrefixes support - Add edge case tests for height-only and different domain images
Contributor
|
@gazal2708 please sign the Adobe CLA |
tripodsan
reviewed
Sep 15, 2025
tripodsan
reviewed
Sep 15, 2025
tripodsan
reviewed
Sep 15, 2025
tripodsan
reviewed
Sep 15, 2025
- Switch from visitParents to visit for better performance - Use Object.assign for direct node property modification - Maintain same functionality with cleaner, more efficient code - All tests passing with 97.77% coverage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please ensure your pull request adheres to the following guidelines:
Related Issues
Thanks for contributing!