chore: eslint speed up #7222
Merged
chore: eslint speed up #7222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reidbarber
approved these changes
Oct 22, 2024
devongovett
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes
Was going to write my own caching, then noticed that someone had made a PR for it azz/eslint-plugin-monorepo#29
I started by adapting the patch, then remembered they'd published my earlier code changes and they also did this one.
It speeds up how long it takes eslint to run for us by ~34s, which is ~50% faster.
Unfortunately it doesn't speed up CircleCI since we run other tasks in parallel with it that are the blockers for this. But it's much less painful locally.
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: