Skip to content

fix: give radio/checkbox position relative so the hidden input is contained #8091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 16, 2025
Merged

fix: give radio/checkbox position relative so the hidden input is contained #8091

merged 3 commits into from
Apr 16, 2025
+2 −0

Conversation

snowystinger
Copy link
Member

@snowystinger snowystinger commented Apr 14, 2025 •
edited
Loading

Closes #8081

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@snowystinger snowystinger mentioned this pull request Apr 14, 2025
Closed
@rspbot
Copy link

rspbot commented Apr 14, 2025

Build successful! 🎉

@snowystinger snowystinger changed the title fix: give radio position relative so the hidden input is contained fix: give radio/checkbox position relative so the hidden input is contained Apr 14, 2025
@rspbot
Copy link

rspbot commented Apr 14, 2025

Build successful! 🎉

@rspbot
Copy link

rspbot commented Apr 14, 2025

Build successful! 🎉

@snowystinger snowystinger added this pull request to the merge queue Apr 16, 2025
Merged via the queue into main with commit 3205f10 Apr 16, 2025
30 checks passed
@snowystinger snowystinger deleted the fix-radio-hidden-positioning branch April 16, 2025 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devongovett devongovett devongovett approved these changes

@reidbarber reidbarber reidbarber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[S2] <RadioGroup/> <Form/> within component that is overflowing-Y will cause layout jump
4 participants
@snowystinger @rspbot @devongovett @reidbarber