chore: Storybook 8 using parcel builder #8272
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # .storybook-s2/docs/Illustrations.jsx # .storybook-s2/docs/Intro.jsx # .storybook-s2/preview.tsx # package.json # packages/@react-spectrum/badge/chromatic-fc/Badge.stories.tsx # packages/@react-spectrum/badge/chromatic/Badge.stories.tsx # packages/@react-spectrum/calendar/stories/Calendar.stories.tsx # packages/@react-spectrum/calendar/stories/RangeCalendar.stories.tsx # packages/@react-spectrum/illustratedmessage/chromatic/IllustratedMessage.Languages.stories.tsx # packages/@react-spectrum/illustratedmessage/chromatic/IllustratedMessage.stories.tsx # yarn.lock
This reverts commit 225c07b.
snowystinger
commented
May 27, 2025
| let { | ||
| UNSAFE_className, | ||
| UNSAFE_style, | ||
| slot, | ||
| 'aria-label': ariaLabel, | ||
| 'aria-hidden': ariaHidden, | ||
| styles, | ||
| // props are already merged with context via rac's useContextProps in generateS2IconIndex |
There was a problem hiding this comment.
potentially problematic for any prop sent over context if it's not meant to end up on an svg element, it'll be both in ctx and in props because of this
so where do we want it? should we even do prop merging in generateS2IconIndex?
snowystinger
changed the title
snowystinger
commented
May 28, 2025
| @@ -12,6 +12,9 @@ | |||
| "@svgr/plugin-jsx": "^8.1.0", | |||
| "@svgr/plugin-svgo": "^8.1.0" | |||
| }, | |||
| "devDependencies": { | |||
| "prettier": "^3.3.3" | |||
There was a problem hiding this comment.
it's a peer of svgo plugin... and results in an install warning
will hopefully go away when we switch to parcel handling svgo
snowystinger
commented
May 28, 2025
| @@ -13,6 +13,9 @@ | |||
| "@svgr/core": "^8.1.0", | |||
| "fs-extra": "^11.0.0" | |||
| }, | |||
| "devDependencies": { | |||
There was a problem hiding this comment.
same, peer of svgr for some reason
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
reidbarber
previously approved these changes
Jun 4, 2025
# Conflicts: # package.json
|
Build successful! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes
Can be reviewed, new
devpackages are actually from parcel-bundler/storybook#5once that's merged, I'll update this PR with the new versions
Note, due to [Bug]: a11y addon shows false positives on page load stories in v3 show an error on initial page load. They go away if you change stories and come back.
S2 seems to be protected from this, not sure why, possibly another addon is interfering
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: