Skip to content

fix: Allow selectedKey=null to clear value in HiddenSelect #8330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

chirokas
Copy link
Contributor

@chirokas chirokas commented Jun 1, 2025

Closes #8032

let onChange = useEffectEvent(() => {
state.commitValidation();
});

runs before
onChange: (e: React.ChangeEvent<HTMLSelectElement>) => state.setSelectedKey(e.target.value)

, which leads to the autofill failing.

See here for more information

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

Copy link
Member

@snowystinger snowystinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appears to leave behaviour for autofill intact for Dashlane. @yihuiliao can you check with chrome's autofill?
Verified it allows the hidden input to be reset to null as expected

@@ -1715,6 +1715,7 @@ describe('Picker', function () {
expect(options.length).toBe(60);
options.forEach((option, index) => index > 0 && expect(option).toHaveTextContent(states[index - 1].name));

fireEvent.input(hiddenSelect, {target: {value: 'CA'}});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just double checking, is this just testing that onSelectionChange isn't called twice? asking because it seems it was passing before the changes in HIddenSelect

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Controlled react-aria-components Select cannot be nulled
2 participants