fix: add shadow dom support for portal provider (S2 v1.0.0, S1 v3.46.0) #9369
+439
−70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsmiley1
changed the title
| */ | ||
|
|
||
| import {CLEAR_FOCUS_EVENT, FOCUS_EVENT, focusWithoutScrolling, getActiveElement, isCtrlKeyPressed, isTabbable, mergeProps, scrollIntoView, scrollIntoViewport, useEvent, useRouter, useUpdateLayoutEffect} from '@react-aria/utils'; | ||
| import {CLEAR_FOCUS_EVENT, FOCUS_EVENT, focusWithoutScrolling, getActiveElement, isCtrlKeyPressed, mergeProps, nodeContains, scrollIntoView, scrollIntoViewport, useEffectEvent, useEvent, useRouter, useUpdateLayoutEffect} from '@react-aria/utils'; |
Member
There was a problem hiding this comment.
looks like isTabbable was incorrectly removed
Member
|
Thanks for the PR, I know you said some more things are coming including a detailed description of the changes. Can you include any references to existing/prior work? I'm starting to refresh myself on all of this work now that our release and docs are out. A bit unfortunate that it's also time for the holiday shutdown, but I am spending some time on this topic this week and a little bit of next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to expand Shadow DOM support by allowing portal components to be opened within a shadow root through the PortalProvider context api.
Pending PDF for a more detailed description of the changes:
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: