Skip to content

chore: add better labels in accordion and dropzone stories for sev1 fixes #9434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
reidbarber merged 5 commits into from
Jan 5, 2026
+12 −12
Merged

chore: add better labels in accordion and dropzone stories for sev1 fixes #9434

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6224e06
Add better labels to accordion and dropzone stories
dannify Jan 2, 2026
6f22833
Add better labels to accordion stories
dannify Jan 2, 2026
4b3c86b
Add better labels to dropzone stories
dannify Jan 2, 2026
948ac10
Add better labels to dropzone stories
dannify Jan 3, 2026
88fb2a5
Add better labels to dropzone stories
dannify Jan 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/@react-spectrum/s2/chromatic/Accordion.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ export const WithActionButton: Story = {
<AccordionItemTitle>
Files
</AccordionItemTitle>
<ActionButton><NewIcon aria-label="new icon" /></ActionButton>
<ActionButton aria-label="Add new file"><NewIcon /></ActionButton>
</AccordionItemHeader>
<AccordionItemPanel>
Files content
Expand All @@ -149,7 +149,7 @@ export const WithActionButton: Story = {
<AccordionItemTitle>
People
</AccordionItemTitle>
<ActionButton><NewIcon aria-label="new icon" /></ActionButton>
<ActionButton aria-label="Add new person"><NewIcon /></ActionButton>
</AccordionItemHeader>
<AccordionItemPanel>
<TextField label="Name" styles={style({maxWidth: 176})} placeholder="Enter your name" />
Expand Down
8 changes: 4 additions & 4 deletions packages/@react-spectrum/s2/chromatic/DropZone.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ const ExampleRender = (args: DropZoneProps): ReactElement => {
<IllustratedMessage>
<DropToUpload />
<Heading>
Drag and drop your file
Drag or paste your file
</Heading>
<Content>
Or, select a file from your computer
Expand Down Expand Up @@ -72,7 +72,7 @@ const ExampleWithFileTriggerRender = (args: DropZoneProps): ReactElement => {
<IllustratedMessage>
<Cloud />
<Heading>
Drag and drop your file
Drag or paste your file
</Heading>
<Content>
Or, select a file from your computer
Expand Down Expand Up @@ -108,7 +108,7 @@ const LongBannerRender = (args: DropZoneProps): ReactElement => {
<IllustratedMessage>
<DropToUpload />
<Heading>
Drag and drop your file
Drag or paste your file
</Heading>
<Content>
Or, select a file from your computer
Expand Down Expand Up @@ -172,7 +172,7 @@ const GradientExample = (args: DropZoneProps): ReactElement => {
<IllustratedMessage>
<CloudUpload />
<Heading>
Drag and drop your file
Drag or paste your file
</Heading>
<Content>
Or, select a file from your computer
Expand Down
4 changes: 2 additions & 2 deletions packages/@react-spectrum/s2/stories/Accordion.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,7 @@ export const WithActionButton: Story = {
<AccordionItemTitle>
Files
</AccordionItemTitle>
<ActionButton><NewIcon aria-label="new icon" /></ActionButton>
<ActionButton aria-label="Add new file"><NewIcon /></ActionButton>
</AccordionItemHeader>
<AccordionItemPanel>
Files content
Expand All @@ -228,7 +228,7 @@ export const WithActionButton: Story = {
<AccordionItemTitle>
People
</AccordionItemTitle>
<ActionButton><NewIcon aria-label="new icon" /></ActionButton>
<ActionButton aria-label="Add new person"><NewIcon /></ActionButton>
</AccordionItemHeader>
<AccordionItemPanel>
<TextField label="Name" styles={style({maxWidth: 176})} placeholder="Enter your name" />
Expand Down
8 changes: 4 additions & 4 deletions packages/@react-spectrum/s2/stories/DropZone.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ const ExampleRender = (args: DropZoneProps): ReactElement => {
<IllustratedMessage>
<DropToUpload />
<Heading>
Drag and drop your file
Drag or paste your file
</Heading>
<Content>
Or, select a file from your computer
Expand Down Expand Up @@ -81,7 +81,7 @@ const ExampleWithFileTriggerRender = (args: DropZoneProps): ReactElement => {
<IllustratedMessage>
<Cloud />
<Heading>
Drag and drop your file
Drag or paste your file
</Heading>
<Content>
Or, select a file from your computer
Expand Down Expand Up @@ -117,7 +117,7 @@ const LongBannerRender = (args: DropZoneProps): ReactElement => {
<IllustratedMessage>
<DropToUpload />
<Heading>
Drag and drop your file
Drag or paste your file
</Heading>
<Content>
Or, select a file from your computer
Expand Down Expand Up @@ -146,7 +146,7 @@ const GradientRender = (args: DropZoneProps): ReactElement => {
<IllustratedMessage>
<CloudUpload />
<Heading>
Drag and drop your file
Drag or paste your file
</Heading>
<Content>
Or, select a file from your computer
Expand Down