Skip to content

fix: Add comment to invoke formsAuditRunner function #1558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: Add comment to invoke formsAuditRunner function #1558

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b8cdaa2
Add comment to invoke formsAuditRunner function
dmaurya929 Nov 12, 2025
c363e86
Comment out opportunity creation functions
dmaurya929 Nov 12, 2025
5070d40
fix: test
dmaurya929 Nov 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions src/forms-opportunities/handler.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,17 +19,14 @@ import {
checkDynamoItem, generateOpptyData, getUrlsDataForAccessibilityAudit,
} from './utils.js';
import { getScrapedDataForSiteId } from '../support/utils.js';
import createLowConversionOpportunities from './oppty-handlers/low-conversion-handler.js';
import createLowNavigationOpportunities from './oppty-handlers/low-navigation-handler.js';
import createLowViewsOpportunities from './oppty-handlers/low-views-handler.js';
import { createAccessibilityOpportunity } from './oppty-handlers/accessibility-handler.js';

const { AUDIT_STEP_DESTINATIONS } = Audit;
const FORMS_OPPTY_QUERIES = [
'cwv',
'form-vitals',
];

// invoke this
export async function formsAuditRunner(auditUrl, context) {
const rumAPIClient = RUMAPIClient.createFrom(context);
const options = {
Expand Down Expand Up @@ -209,16 +206,16 @@ export async function sendA11yUrlsForScrapingStep(context) {

export async function processOpportunityStep(context) {
const {
// eslint-disable-next-line no-unused-vars
log, site, finalUrl,
} = context;

log.debug(`[Form Opportunity] [Site Id: ${site.getId()}] processing opportunity`);
// eslint-disable-next-line no-unused-vars
const scrapedData = await getScrapedDataForSiteId(site, context);
const latestAudit = await site.getLatestAuditByAuditType('forms-opportunities');
// eslint-disable-next-line no-unused-vars
const excludeForms = new Set();
await createLowNavigationOpportunities(finalUrl, latestAudit, scrapedData, context, excludeForms);
await createLowViewsOpportunities(finalUrl, latestAudit, scrapedData, context, excludeForms);
await createLowConversionOpportunities(finalUrl, latestAudit, scrapedData, context, excludeForms);
await createAccessibilityOpportunity(latestAudit, context);
log.debug(`[Form Opportunity] [Site Id: ${site.getId()}] opportunity identified`);
return {
Expand Down