-
Notifications
You must be signed in to change notification settings - Fork 15
fix: prerender audit adding agentic urls #1598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
anuj-adobe
wants to merge
18
commits into
main
Choose a base branch
from
prerender
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+939
−99
Open
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
3a537c8
fix: adding agentic urls
anuj-adobe 8453085
temp: reducing urls for testings
anuj-adobe e2347b9
Merge branch 'main' into prerender
anuj-adobe 0beac30
fix: adding debug statements for athena queries
anuj-adobe 756d587
fix: extracting agentic urls from sheet
anuj-adobe 4a920ef
fix: using athena query for agentic urls
anuj-adobe 25f645b
temp: increasing agentic urls limit to 50
anuj-adobe c422540
fix: update traffic for includedURLs
anuj-adobe e5668b2
fix: removing unwanted test
anuj-adobe bd6a86d
fix: return auditResult and fullAuditRef in first step
anuj-adobe 1613fc1
Merge branch 'main' into prerender
anuj-adobe 68c4f5f
fix: adding a sheet fallback for agentic urls
anuj-adobe 890b3a4
temp: reducing urls limit to 10 for testing
anuj-adobe e34ee7c
temp: getTopAgenticUrlsFromSheet
anuj-adobe be156d5
fix: refactoring
anuj-adobe 2129e25
fix: trafficDuration as object
anuj-adobe c386d20
fix: adding tests
anuj-adobe fcfee80
fix: syncing with main
anuj-adobe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| SELECT | ||
| url, | ||
| SUM(number_of_hits) AS number_of_hits | ||
| FROM {{databaseName}}.{{tableName}} | ||
| {{whereClause}} | ||
| AND url IN ({{urlList}}) | ||
| GROUP BY url; | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as there can be so many urls,
use limit 200 and orderby number_of_hits DESC here
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This query is required to find the agentic traffic for URLs that are added over top 200 agentic URLs (by updating site config for prerender handler using "includedURLs"). The extra added URLs might not be present in top 200 URLs. I don't think limit 200 will help in this case and we need to scan all the URLs