Skip to content

Update Suggestion model with NOT_VALID status #1066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Nov 14, 2025
+21 −1
Merged

Update Suggestion model with NOT_VALID status #1066

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
7f636c3
Update Suggestion model with NOT_VALID status
Sugandhgyl Oct 29, 2025
2352a7e
Update package lock
Sugandhgyl Oct 29, 2025
d72313d
Add requiresValidation key in site object
Sugandhgyl Oct 30, 2025
9c6d2b4
Revert unintended changes to package-lock.json
Sugandhgyl Oct 31, 2025
a61e600
feature: remove unused changes
Sugandhgyl Oct 31, 2025
3de4032
Revert package-lock.json changes
Sugandhgyl Oct 31, 2025
a0d35f3
Merge branch 'main' of github-personal:adobe/spacecat-shared into sug…
Sugandhgyl Oct 31, 2025
620a1d6
Revert changes
Sugandhgyl Nov 6, 2025
a4bdd11
Add tests for not validated suggestion
Sugandhgyl Nov 6, 2025
eef1849
Rename not validated to PENDING_VALIDATION
Sugandhgyl Nov 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/spacecat-shared-data-access/src/models/suggestion/suggestion.model.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ class Suggestion extends BaseModel {
FIXED: 'FIXED',
ERROR: 'ERROR',
OUTDATED: 'OUTDATED',
PENDING_VALIDATION: 'PENDING_VALIDATION',
};

static TYPES = {
Expand Down
2 changes: 1 addition & 1 deletion ...ges/spacecat-shared-data-access/test/unit/models/suggestion/suggestion.collection.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ describe('SuggestionCollection', () => {

it('throws an error if status is not provided', async () => {
await expect(instance.bulkUpdateStatus([model], 'foo'))
.to.be.rejectedWith('Invalid status: foo. Must be one of: NEW, APPROVED, IN_PROGRESS, SKIPPED, FIXED, ERROR');
.to.be.rejectedWith('Invalid status: foo. Must be one of: NEW, APPROVED, IN_PROGRESS, SKIPPED, FIXED, ERROR, OUTDATED, PENDING_VALIDATION');
});
});

Expand Down
19 changes: 19 additions & 0 deletions packages/spacecat-shared-data-access/test/unit/models/suggestion/suggestion.model.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,20 @@ chaiUse(chaiAsPromised);
chaiUse(sinonChai);

describe('SuggestionModel', () => {
describe('STATUSES', () => {
it('has STATUSES enum', () => {
expect(Suggestion.STATUSES).to.be.an('object');
expect(Suggestion.STATUSES.NEW).to.equal('NEW');
expect(Suggestion.STATUSES.APPROVED).to.equal('APPROVED');
expect(Suggestion.STATUSES.IN_PROGRESS).to.equal('IN_PROGRESS');
expect(Suggestion.STATUSES.SKIPPED).to.equal('SKIPPED');
expect(Suggestion.STATUSES.FIXED).to.equal('FIXED');
expect(Suggestion.STATUSES.ERROR).to.equal('ERROR');
expect(Suggestion.STATUSES.OUTDATED).to.equal('OUTDATED');
expect(Suggestion.STATUSES.PENDING_VALIDATION).to.equal('PENDING_VALIDATION');
});
});

let instance;

let mockElectroService;
Expand Down Expand Up @@ -90,6 +104,11 @@ describe('SuggestionModel', () => {
instance.setStatus('OUTDATED');
expect(instance.record.status).to.equal('OUTDATED');
});

it('sets the status of the suggestion to PENDING_VALIDATION', () => {
instance.setStatus('PENDING_VALIDATION');
expect(instance.record.status).to.equal('PENDING_VALIDATION');
});
});

describe('getRank and setRank', () => {
Expand Down