-
Notifications
You must be signed in to change notification settings - Fork 15
fix(spacecat-shared-data-access/src/models/site/config.js): add suppo… #1118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
davidaurelio
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please update spacecat-shared-utils/src/schemas.js instead.
…upport AI prompts
2734851 to
060a396
Compare
|
This PR will trigger a patch release when merged. |
davidaurelio
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
almost good to go:
- please remove
tokowakaConfig - deduplicate topic verification
davidaurelio
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
more comments
| entities: z.record(z.uuid(), entity), | ||
| categories: z.record(z.uuid(), category), | ||
| topics: z.record(z.uuid(), topic), | ||
| ai_topics: z.record(z.uuid(), topic).optional(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we make this camel case by any chance? It's unfortunate that we have diverging standards in JS and Python.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
with CamelCaseModel on the Mystique side it should be possible to bridge the gap
Co-authored-by: David Aurelio <[email protected]>
Co-authored-by: David Aurelio <[email protected]>
…cs and fix validateTopicPromptRegions signature
davidaurelio
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
# [@adobe/spacecat-shared-utils-v1.72.1](https://github.com/adobe/spacecat-shared/compare/@adobe/spacecat-shared-utils-v1.72.0...@adobe/spacecat-shared-utils-v1.72.1) (2025-11-13) ### Bug Fixes * **spacecat-shared-data-access/src/models/site/config.js:** add suppo… ([#1118](#1118)) ([7123b3c](7123b3c))
|
🎉 This PR is included in version @adobe/spacecat-shared-utils-v1.72.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
…rt for AI generated prompts
Please ensure your pull request adheres to the following guidelines:
Related Issues
Thanks for contributing!