Skip to content

Conversation

@byteclimber
Copy link
Contributor

…rt for AI generated prompts

Please ensure your pull request adheres to the following guidelines:

  • make sure to link the related issues in this description
  • when merging / squashing, make sure the fixed issue references are visible in the commits, for easy compilation of release notes

Related Issues

Thanks for contributing!

Copy link
Member

@davidaurelio davidaurelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update spacecat-shared-utils/src/schemas.js instead.

@byteclimber byteclimber force-pushed the support-ai-prompts-field branch from 2734851 to 060a396 Compare November 12, 2025 13:33
@github-actions
Copy link

This PR will trigger a patch release when merged.

Copy link
Member

@davidaurelio davidaurelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almost good to go:

  • please remove tokowakaConfig
  • deduplicate topic verification

Copy link
Member

@davidaurelio davidaurelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

more comments

entities: z.record(z.uuid(), entity),
categories: z.record(z.uuid(), category),
topics: z.record(z.uuid(), topic),
ai_topics: z.record(z.uuid(), topic).optional(),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we make this camel case by any chance? It's unfortunate that we have diverging standards in JS and Python.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with CamelCaseModel on the Mystique side it should be possible to bridge the gap

Copy link
Member

@davidaurelio davidaurelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@byteclimber byteclimber merged commit 7123b3c into main Nov 13, 2025
7 checks passed
@byteclimber byteclimber deleted the support-ai-prompts-field branch November 13, 2025 10:33
solaris007 pushed a commit that referenced this pull request Nov 13, 2025
# [@adobe/spacecat-shared-utils-v1.72.1](https://github.com/adobe/spacecat-shared/compare/@adobe/spacecat-shared-utils-v1.72.0...@adobe/spacecat-shared-utils-v1.72.1) (2025-11-13)

### Bug Fixes

* **spacecat-shared-data-access/src/models/site/config.js:** add suppo… ([#1118](#1118)) ([7123b3c](7123b3c))
@solaris007
Copy link
Member

🎉 This PR is included in version @adobe/spacecat-shared-utils-v1.72.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants