docs(button,icon): remove MDX files

[marissahuysentruyt]

Description

This is the final installment in child PRs for CSS-986, where we are removing any unnecessary MDX documentation files. This PR migrates any documentation from MDX files to the component's *.stories.js file. No loss of documentation should have occurred, but minor changes, like correcting story names to organize similar stories together or reorganizing content now that there is not an MDX file or fixing sentence-casing, is acceptable. The components affected in this PR include button, icon, and typography. For each component, we have:

• deleted mdx file in favor of all docs being moved into stories file
• updated some story names to follow sentence-casing and organize like- stories together
• in the case of icon, moved any markup related templates into the template.js file (which then makes it consistent with all other components)
• in the case of typography, we elected to keep the MDX file. I only replaced an internal note with external documentation.

No changeset is required for any of the components since no CSS is changed. VRT is unnecessary.

Jira/Specs

CSS-1051

How and where has this been tested?

Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.

Validation steps

• Pull down the branch to run locally or visit the deploy preview.
• Visit the button docs page.
• Verify the information on the docs page matches the production docs page for button.
• Repeat the process for the following components:
  • icon (here's the PR link to compare to icon's production links: icon's production)
  • typography (and this PR link to compare to typography's production)

Regression testing

Validate:

1. The documentation pages for at least two other components are still loading, including:

• The pages render correctly, are accessible, and are responsive.

2. If components have been modified, VRTs have been run on this branch:

• VRTs have been run and looked at.
• Any VRT changes have been accepted (by reviewer and/or PR author), or there are no changes. (@marissahuysentruyt this PR is a docs-only change)

Screenshots

To-do list

• I have read the contribution guidelines.
• I have updated relevant storybook stories and templates.
• I have tested these changes in Windows High Contrast mode.
• If my change impacts other components, I have tested to make sure they don't break.
• If my change impacts documentation, I have updated the documentation accordingly.
• ✨ This pull request is ready to merge. ✨

[changeset-bot]

⚠️ No Changeset found

Latest commit: 2870bc9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[github-actions]

File metrics

Summary

Total size: 2.24 MB^*

🎉 No changes detected in any packages

* Size is the sum of all main files for packages in the library.
* An ASCII character in UTF-8 is 8 bits or 1 byte.

[github-actions]

🚀 Deployed on https://pr-3636--spectrum-css.netlify.app

[marissahuysentruyt]

Typography is the only component where I have pretty strong feelings that we should keep the MDX file. To me, the organization of the MDX file better suits these docs, as opposed to just alphabetically listing everything. We can absolutely move all of the documentation into the stories file, it's totally possible, and I don't think we're losing any of the docs.

However, I think the current flow of the information on prod regarding the typography component seems more accessible and understandable to a user. It makes more sense to me.

Is that just my personal preference? Thoughts on reverting the typography changes and keeping the MDX file?

[marissahuysentruyt]

This felt like a todo that we missed and it ended up getting published! 😆 Any suggestions on what we want to say here instead?

[jawinn]

This looks good to me. I just had one minor suggestion for one of the story titles.

[rise-erpelding]

Looks great! Thanks for all of the extra little touches you added in; while we can't control the story order as well on a docs page, I think the organization is better overall in this new version!