feat(actionbar): new s2 migration #3657
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0e43d2d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
aramos-adobe
added
size-5 L
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| --spectrum-actionbar-emphasized-item-counter-color: var(--spectrum-white); | ||
| --spectrum-actionbar-emphasized-background-color: var(--spectrum-neutral-content-color-default); | ||
| --spectrum-actionbar-emphasized-item-counter-color: var(--spectrum-gray-25); | ||
| --spectrum-actionbar-emphasized-actionbutton-label-color: var(--spectrum-gray-25); |
There was a problem hiding this comment.
Custom property --spectrum-actionbar-emphasized-actionbutton-label-color's references have been removed
components/actiongroup/index.css
Outdated
| @@ -21,6 +21,10 @@ | |||
| --spectrum-actiongroup-button-spacing-reset: 0; | |||
| --spectrum-actiongroup-border-radius-reset: 0; | |||
| --spectrum-actiongroup-border-radius: var(--spectrum-corner-radius-100); | |||
| --spectrum-actiongroup-gap-size-compact: var(--spectrum-spacing-50); | |||
There was a problem hiding this comment.
Unexpected duplicate "--spectrum-actiongroup-gap-size-compact"
components/checkbox/index.css
Outdated
| @@ -32,6 +32,11 @@ | |||
| --spectrum-checkbox-content-color-down: var(--spectrum-neutral-content-color-down); | |||
| --spectrum-checkbox-content-color-focus: var(--spectrum-neutral-content-color-key-focus); | |||
|
|
|||
| --spectrum-checkbox-control-color-default: var(--spectrum-gray-600); | |||
There was a problem hiding this comment.
Unexpected duplicate "--spectrum-checkbox-control-color-default"
components/checkbox/index.css
Outdated
| @@ -32,6 +32,11 @@ | |||
| --spectrum-checkbox-content-color-down: var(--spectrum-neutral-content-color-down); | |||
| --spectrum-checkbox-content-color-focus: var(--spectrum-neutral-content-color-key-focus); | |||
|
|
|||
| --spectrum-checkbox-control-color-default: var(--spectrum-gray-600); | |||
| --spectrum-checkbox-control-color-hover: var(--spectrum-gray-700); | |||
There was a problem hiding this comment.
Unexpected duplicate "--spectrum-checkbox-control-color-hover"
components/checkbox/index.css
Outdated
| @@ -32,6 +32,11 @@ | |||
| --spectrum-checkbox-content-color-down: var(--spectrum-neutral-content-color-down); | |||
| --spectrum-checkbox-content-color-focus: var(--spectrum-neutral-content-color-key-focus); | |||
|
|
|||
| --spectrum-checkbox-control-color-default: var(--spectrum-gray-600); | |||
| --spectrum-checkbox-control-color-hover: var(--spectrum-gray-700); | |||
| --spectrum-checkbox-control-color-down: var(--spectrum-gray-800); | |||
There was a problem hiding this comment.
Unexpected duplicate "--spectrum-checkbox-control-color-down"
components/tabs/index.css
Outdated
| @@ -37,6 +37,7 @@ | |||
| --spectrum-tabs-font-style: var(--spectrum-default-font-style); | |||
| --spectrum-tabs-font-size: var(--spectrum-font-size-100); | |||
| --spectrum-tabs-line-height: var(--spectrum-line-height-100); | |||
| --spectrum-tabs-font-weight: var(--spectrum-regular-font-weight); | |||
There was a problem hiding this comment.
Unexpected duplicate "--spectrum-tabs-font-weight"
components/textfield/index.css
Outdated
| --spectrum-textfield-border-color-focus-hover: var(--spectrum-gray-900); | ||
| --spectrum-textfield-border-color-keyboard-focus: var(--spectrum-gray-900); | ||
|
|
||
| --spectrum-textfield-border-width: var(--spectrum-border-width-100); |
There was a problem hiding this comment.
Unexpected duplicate "--spectrum-textfield-border-width"
components/toast/index.css
Outdated
| @@ -51,9 +51,11 @@ | |||
| --spectrum-toast-spacing-bottom-edge-to-text: var(--spectrum-toast-bottom-to-text); | |||
|
|
|||
| /* Color */ | |||
| --spectrum-toast-background-color-default: var(--spectrum-neutral-subdued-background-color-default); | |||
There was a problem hiding this comment.
Unexpected duplicate "--spectrum-toast-background-color-default"
components/toast/index.css
Outdated
| --spectrum-toast-negative-background-color-default: var(--spectrum-negative-background-color-default); | ||
| --spectrum-toast-positive-background-color-default: var(--spectrum-positive-background-color-default); | ||
| --spectrum-toast-informative-background-color-default: var(--spectrum-informative-background-color-default); | ||
| --spectrum-toast-divider-color: var(--spectrum-transparent-white-400); |
There was a problem hiding this comment.
Unexpected duplicate "--spectrum-toast-divider-color"
components/well/index.css
Outdated
| @@ -15,6 +15,7 @@ | |||
| --spectrum-well-border-color: rgba(var(--spectrum-gray-1000-rgb), 0.05); | |||
|
|
|||
| --spectrum-well-border-width: var(--spectrum-border-width-100); | |||
| --spectrum-well-border-color: rgba(var(--spectrum-gray-1000-rgb), .05); | |||
There was a problem hiding this comment.
Unexpected duplicate "--spectrum-well-border-color"
File metricsSummaryTotal size: 1.37 MB* Table reports on changes to a package's main file. Other changes can be found in the collapsed Details section below.
File change detailsactionbar
actiongroup
card
checkbox
combobox
infieldbutton
logicbutton
page
radio
steplist
table
tabs
tag
textfield
toast
well
tokens
ui-icons
* An ASCII character in UTF-8 is 8 bits or 1 byte. |
| @@ -2,7 +2,8 @@ import { Template as ButtonGroup } from "@spectrum-css/buttongroup/stories/templ | |||
| import { Template as Checkbox } from "@spectrum-css/checkbox/stories/template.js"; | |||
| import { Template as CloseButton } from "@spectrum-css/closebutton/stories/template.js"; | |||
| import { Template as Modal } from "@spectrum-css/modal/stories/template.js"; | |||
| import { getRandomId, renderContent } from "@spectrum-css/preview/decorators"; | |||
| import { getRandomId } from "@spectrum-css/preview/decorators"; | |||
| import { Template as Typography } from "@spectrum-css/typography/stories/template.js"; | |||
There was a problem hiding this comment.
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'Typography' is defined but never used.
|
🚀 Deployed on https://pr-3657--spectrum-css.netlify.app |
aramos-adobe
force-pushed
the
aramos-adobe/css1027-action-bar-s2-migration
branch
from
701ca81 to
0e43d2d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actionbar S2 Migration
Action bar now has some updated colors, corner radius, icons and outline has been removed. The default and emphasized variant now have a light and dark mode theme.
The emphasized variant has visibily changed from blue to gray.
New tokens
--spectrum-actionbar-emphasized-actionbutton-label-color--spectrum-actionbar-emphasized-icon-color--spectrum-actionbar-minimum-width--spectrum-actionbar-spacing-label-to-actiongroup--spectrum-actionbar-spacing-action-group-edgeNew mods
--mod-actionbar-minimum-width--mod-actionbar-spacing-action-group-edge--mod-actionbar-spacing-label-to-actiongroupHow and where has this been tested?
Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.
Validation steps
Regression testing
Validate:
Screenshots
To-do list