Skip to content

fix(icons): added missing workflow icons #5367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 17, 2025

Conversation

Rajdeepc
Copy link
Contributor

@Rajdeepc Rajdeepc commented Apr 11, 2025

Description

Below S2 icons are added [4.1.0]

- S2_Icon_ABC_20_N.svg
- S2_Icon_App_20_N.svg
- S2_Icon_Bookmark_20_N.svg
- S2_Icon_Building_20_N.svg
- S2_Icon_CallCenter_20_N.svg
- S2_Icon_ChartBarVert_20_N.svg
- S2_Icon_ChartPie_20_N.svg
- S2_Icon_ChartTrend_20_N.svg
- S2_Icon_Chat_20_N.svg
- S2_Icon_ChevronDoubleLeft_20_N.svg
- S2_Icon_ChevronDoubleRight_20_N.svg
- S2_Icon_ChevronUp_20_N.svg
- S2_Icon_Code_20_N.svg
- S2_Icon_Compare_20_N.svg
- S2_Icon_DataRefresh_20_N.svg
- S2_Icon_Enterprise_20_N.svg
- S2_Icon_Export_20_N.svg
- S2_Icon_FolderSearch_20_N.svg
- S2_Icon_Import_20_N.svg
- S2_Icon_Key_20_N.svg
- S2_Icon_PeopleGroup_20_N.svg
- S2_Icon_SaveFloppy_20_N.svg
- S2_Icon_SpeedFast_20_N.svg
- S2_Icon_UserSettings_20_N.svg
- S2_Icon_ViewGridFluid_20_N.svg

Related issue(s)

  • SWC-795

Motivation and context

adobe/spectrum-css-workflow-icons#48

How has this been tested?

  • Test case 1

    1. Go here
    2. Search for the any of the above icons by searching by Building for S2_Icon_Building_20_N.svg and so on. :)
  • Did it pass in Desktop?

  • Did it pass in Mobile?

  • Did it pass in iPad?

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Checklist

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • If my change required a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have reviewed at the Accessibility Practices for this feature, see: Aria Practices

Best practices

This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against main.

@Rajdeepc Rajdeepc self-assigned this Apr 11, 2025
@Rajdeepc Rajdeepc requested a review from a team as a code owner April 11, 2025 15:24
Copy link

changeset-bot bot commented Apr 11, 2025

🦋 Changeset detected

Latest commit: 09376ef

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 84 packages
Name Type
@spectrum-web-components/icons-workflow Minor
@spectrum-web-components/action-group Minor
@spectrum-web-components/action-menu Minor
@spectrum-web-components/alert-banner Minor
@spectrum-web-components/alert-dialog Minor
@spectrum-web-components/breadcrumbs Minor
@spectrum-web-components/card Minor
@spectrum-web-components/contextual-help Minor
@spectrum-web-components/dialog Minor
@spectrum-web-components/help-text Minor
@spectrum-web-components/picker Minor
@spectrum-web-components/search Minor
@spectrum-web-components/textfield Minor
@spectrum-web-components/toast Minor
@spectrum-web-components/vrt-compare Minor
@spectrum-web-components/bundle Minor
@spectrum-web-components/action-bar Minor
@spectrum-web-components/field-group Minor
@spectrum-web-components/radio Minor
@spectrum-web-components/custom-vars-viewer Minor
example-project-rollup Patch
example-project-webpack Patch
@spectrum-web-components/story-decorator Minor
@spectrum-web-components/color-field Minor
@spectrum-web-components/combobox Minor
@spectrum-web-components/number-field Minor
documentation Patch
@spectrum-web-components/slider Minor
@spectrum-web-components/eslint-plugin Minor
@spectrum-web-components/accordion Minor
@spectrum-web-components/action-button Minor
@spectrum-web-components/asset Minor
@spectrum-web-components/avatar Minor
@spectrum-web-components/badge Minor
@spectrum-web-components/button-group Minor
@spectrum-web-components/button Minor
@spectrum-web-components/checkbox Minor
@spectrum-web-components/clear-button Minor
@spectrum-web-components/close-button Minor
@spectrum-web-components/coachmark Minor
@spectrum-web-components/color-area Minor
@spectrum-web-components/color-handle Minor
@spectrum-web-components/color-loupe Minor
@spectrum-web-components/color-slider Minor
@spectrum-web-components/color-wheel Minor
@spectrum-web-components/divider Minor
@spectrum-web-components/dropzone Minor
@spectrum-web-components/field-label Minor
@spectrum-web-components/icon Minor
@spectrum-web-components/icons-ui Minor
@spectrum-web-components/icons Minor
@spectrum-web-components/iconset Minor
@spectrum-web-components/illustrated-message Minor
@spectrum-web-components/infield-button Minor
@spectrum-web-components/link Minor
@spectrum-web-components/menu Minor
@spectrum-web-components/meter Minor
@spectrum-web-components/modal Minor
@spectrum-web-components/overlay Minor
@spectrum-web-components/picker-button Minor
@spectrum-web-components/popover Minor
@spectrum-web-components/progress-bar Minor
@spectrum-web-components/progress-circle Minor
@spectrum-web-components/sidenav Minor
@spectrum-web-components/split-view Minor
@spectrum-web-components/status-light Minor
@spectrum-web-components/swatch Minor
@spectrum-web-components/switch Minor
@spectrum-web-components/table Minor
@spectrum-web-components/tabs Minor
@spectrum-web-components/tags Minor
@spectrum-web-components/thumbnail Minor
@spectrum-web-components/tooltip Minor
@spectrum-web-components/top-nav Minor
@spectrum-web-components/tray Minor
@spectrum-web-components/underlay Minor
@spectrum-web-components/base Minor
@spectrum-web-components/grid Minor
@spectrum-web-components/opacity-checkerboard Minor
@spectrum-web-components/reactive-controllers Minor
@spectrum-web-components/shared Minor
@spectrum-web-components/styles Minor
@spectrum-web-components/theme Minor
@spectrum-web-components/truncated Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rajdeepc Rajdeepc marked this pull request as draft April 11, 2025 15:30
@Rajdeepc Rajdeepc marked this pull request as ready for review April 14, 2025 08:05
Copy link

Branch preview

Review the following VRT differences

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

If the changes are expected, update the current_golden_images_cache hash in the circleci config to accept the new images. Instructions are included in that file.
If the changes are unexpected, you can investigate the cause of the differences and update the code accordingly.

Copy link

Tachometer results

Currently, no packages are changed by this PR...

@nikkimk
Copy link
Contributor

nikkimk commented Apr 14, 2025

@Rajdeepc can you please add testing instructions to your PR description?

@Rajdeepc
Copy link
Contributor Author

@Rajdeepc can you please add testing instructions to your PR description?

Apologies! Should be there now.

@Rajdeepc Rajdeepc merged commit f6cebbd into main Apr 17, 2025
24 checks passed
@Rajdeepc Rajdeepc deleted the rajdeep/added-missing-workflow-icons branch April 17, 2025 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants