chore(tabs): update access modifiers, changedProperties type

[lehelen19]

Description

Changes the access modifiers for some properties of Tabs and TabsOverflow. Also updates the deprecated type of changedProperties to PropertyValues.

Related issue(s)

• Change access modifiers for Tabs methods to be more extensible #5368
• Replace deprecated PropertyValueMap type with PropertyValues #5369

Motivation and context

Child classes extending from Tabs and TabsOverflow can access previously guarded properties of the parent class.
PropertyValueMap is deprecated by Lit, and PropertyValues is preferred (Lit docs).

How has this been tested?

• Test case 1

  1. Go here
  2. Do this

• Test case 2

  1. Go here
  2. Do this

• Did it pass in Desktop?

• Did it pass in Mobile?

• Did it pass in iPad?

Screenshots (if appropriate)

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Checklist

• I have signed the Adobe Open Source CLA.
• My code follows the code style of this project.
• If my change required a change to the documentation, I have updated the documentation in this pull request.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.
• I have reviewed at the Accessibility Practices for this feature, see: Aria Practices

Best practices

This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against main.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 7c552ca

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[Rajdeepc]

Hey these are indeed going points you raised here! Changing these modifiers to protected can extend the property behaviour but it slightly deviates from the component's inheritance contract. I will discuss with my team and circle back here.

[Rajdeepc]

Once we make this protected, if we want to change these in the future, it becomes a breaking change for subclasses.

[caseyisonit]

@Rajdeepc do we have a status update for this or should we bring it up in our team meeting to discuss?