chore: lock playwright version [swc-829] by castastrophe · Pull Request #5414 · adobe/spectrum-web-components

castastrophe · 2025-04-29T15:45:41Z

Description

Related issue(s)

Motivation and context

How has this been tested?

Screenshots (if appropriate)

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Checklist

I have signed the Adobe Open Source CLA.
My code follows the code style of this project.
If my change required a change to the documentation, I have updated the documentation in this pull request.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
All new and existing tests passed.
I have reviewed at the Accessibility Practices for this feature, see: Aria Practices

Best practices

This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against main.

changeset-bot · 2025-04-29T15:45:45Z

⚠️ No Changeset found

Latest commit: a5f2232

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions · 2025-04-29T15:52:09Z

Branch preview

Review the following VRT differences

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

If the changes are expected, update the current_golden_images_cache hash in the circleci config to accept the new images. Instructions are included in that file.
If the changes are unexpected, you can investigate the cause of the differences and update the code accordingly.

github-actions · 2025-04-29T15:58:33Z

Tachometer results

Currently, no packages are changed by this PR...

castastrophe · 2025-04-29T18:10:12Z

 import { sendKeys } from '@web/test-runner-commands';

 describe('NumberField - inputs', () => {
-    before(async () => {


CanIUse indicates that the international number field has been available in our supported evergreen - 2 so we can remove the polyfills now

castastrophe · 2025-04-29T18:11:51Z

    private host: ReactiveElement;
-    language = document.documentElement.lang || navigator.language;
+    get language(): string {
+        return document.documentElement.lang || navigator.language;


This is fetching the root-level language but shouldn't we also be honoring if the language attribute is set on a container too?

this change is what is causing a majority of the number field failing tests, I would like to revert it since its out of scope for this specifically and capture this idea somehow for when we refactor number field.

Those tests were failing before as well - I added this change to resolve the first round of issues I saw. You can see the details outlined in the Jira ticket.

The first error I identified was on NumberField which threw an error that locale was invalid on every instance. I fixed this according to similar debugging advice I found online by converting any manually provided locales with underscores to dashes.

thats odd, when i reverted it the tests passed. I'm going to do a fresh clone again to make sure it wasn't something weird on my local. thank you for this context and apologies I missed that from the ticket.

github-actions · 2025-06-19T18:22:13Z

        ]
-    }
+    },
+    "extends": [


🚫 [eslint] <no-dupe-keys> _{reported by reviewdog 🐶}
Duplicate key 'extends'.

github-actions · 2025-06-19T18:22:13Z

+        "plugin:lit-a11y/recommended",
+        "plugin:require-extensions/recommended"
+    ],
+    "overrides": [


🚫 [eslint] <no-dupe-keys> _{reported by reviewdog 🐶}
Duplicate key 'overrides'.

github-actions · 2025-06-19T18:22:13Z

@@ -19,7 +19,7 @@ import prettier from 'prettier';
 import Case from 'case';


🚫 [eslint] <import/no-extraneous-dependencies> _{reported by reviewdog 🐶}
'case' should be listed in the project's dependencies, not devDependencies.

github-actions · 2025-06-23T20:05:20Z

🚫 [eslint] <notice/notice> _{reported by reviewdog 🐶}
Missing notice header

https://github.com/adobe/spectrum-web-components/blob/a5f2232defbe5423d5e0ee59c98b6eabcfed85cc/.eslintrc.json#L1-L195

github-actions · 2025-06-23T20:05:21Z

🚫 [eslint] <notice/notice> _{reported by reviewdog 🐶}
Missing notice header

https://github.com/adobe/spectrum-web-components/blob/a5f2232defbe5423d5e0ee59c98b6eabcfed85cc/package.json#L1-L422

github-actions · 2025-06-23T20:05:22Z

🚫 [eslint] <notice/notice> _{reported by reviewdog 🐶}
Missing notice header

https://github.com/adobe/spectrum-web-components/blob/a5f2232defbe5423d5e0ee59c98b6eabcfed85cc/tools/reactive-controllers/package.json#L1-L103

castastrophe force-pushed the castastrophe/swc-829-playwright-lock branch from 05d38b3 to d1f97c0 Compare April 29, 2025 15:52

castastrophe force-pushed the castastrophe/swc-829-playwright-lock branch 6 times, most recently from 16ac9a1 to f28b5e9 Compare April 29, 2025 17:06

castastrophe commented Apr 29, 2025

View reviewed changes

castastrophe force-pushed the castastrophe/swc-829-playwright-lock branch 5 times, most recently from e41803d to cf33dd2 Compare May 12, 2025 13:29

castastrophe force-pushed the castastrophe/swc-829-playwright-lock branch 8 times, most recently from 1d4606b to 95f97c1 Compare May 13, 2025 20:27

castastrophe force-pushed the castastrophe/swc-829-playwright-lock branch from 95f97c1 to 74fbb10 Compare May 27, 2025 13:53

castastrophe force-pushed the castastrophe/swc-829-playwright-lock branch from 74fbb10 to 71b894f Compare June 19, 2025 18:19

github-actions Bot reviewed Jun 19, 2025

View reviewed changes

castastrophe force-pushed the castastrophe/swc-829-playwright-lock branch from 71b894f to 4ce24bf Compare June 19, 2025 18:26

chore: lock playwright version [swc-829]

a5f2232

castastrophe force-pushed the castastrophe/swc-829-playwright-lock branch from 4ce24bf to a5f2232 Compare June 23, 2025 20:02

github-actions Bot reviewed Jun 23, 2025

View reviewed changes

castastrophe closed this Aug 20, 2025

		@@ -19,7 +19,7 @@ import prettier from 'prettier';
		import Case from 'case';

Conversation

castastrophe commented Apr 29, 2025

Description

Related issue(s)

Motivation and context

How has this been tested?

Screenshots (if appropriate)

Types of changes

Checklist

Best practices

Uh oh!

changeset-bot Bot commented Apr 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

github-actions Bot commented Apr 29, 2025

Branch preview

Review the following VRT differences

Uh oh!

github-actions Bot commented Apr 29, 2025

Tachometer results

Uh oh!

castastrophe Apr 29, 2025

Choose a reason for hiding this comment

Uh oh!

castastrophe Apr 29, 2025

Choose a reason for hiding this comment

Uh oh!

caseyisonit May 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

castastrophe May 13, 2025

Choose a reason for hiding this comment

Uh oh!

caseyisonit May 19, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jun 19, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jun 19, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jun 19, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jun 23, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jun 23, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jun 23, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

changeset-bot Bot commented Apr 29, 2025 •

edited

Loading

caseyisonit May 12, 2025 •

edited

Loading