Skip to content

fix: get tests passing on latest playwright version #5471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: castastrophe/swc-829-playwright-lock
Choose a base branch
from

Conversation

caseyisonit
Copy link
Contributor

Description

Get tests passing with playwright at latest

Motivation and context

to bump playwright to latest

Related issue(s)

  • fixes [Issue Number]

Screenshots (if appropriate)


Author's checklist

  • I have read the CONTRIBUTING and PULL_REQUESTS documents.
  • I have reviewed at the Accessibility Practices for this feature, see: Aria Practices
  • I have added automated tests to cover my changes.
  • I have included a well-written changeset if my change needs to be published.
  • I have included updated documentation if my change required it.

Reviewer's checklist

  • Includes a Github Issue with appropriate flag or Jira ticket number without a link
  • Includes thoughtfully written changeset if changes suggested include patch, minor, or major features
  • Automated tests cover all use cases and follow best practices for writing
  • Validated on all supported browsers
  • All VRTs are approved before the author can update Golden Hash

Manual review test cases

  • Tests pass in CI

@caseyisonit caseyisonit requested a review from a team as a code owner May 13, 2025 16:28
Copy link

changeset-bot bot commented May 13, 2025

⚠️ No Changeset found

Latest commit: 1d47302

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

Branch preview

Review the following VRT differences

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

If the changes are expected, update the current_golden_images_cache hash in the circleci config to accept the new images. Instructions are included in that file.
If the changes are unexpected, you can investigate the cause of the differences and update the code accordingly.

Copy link

Tachometer results

Currently, no packages are changed by this PR...

@caseyisonit caseyisonit changed the title fix: revert LanguageResolution change and add todo fix: get tests passing on latest playwright version May 13, 2025
@castastrophe castastrophe force-pushed the castastrophe/swc-829-playwright-lock branch from 1d4606b to 95f97c1 Compare May 13, 2025 20:27
@castastrophe castastrophe force-pushed the castastrophe/swc-829-playwright-lock branch from 95f97c1 to 74fbb10 Compare May 27, 2025 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants