Adopting Prettier for templates in the adopted-ember-addons org

[patocallaghan]

This came out of a question I asked in the #adopted-ember-addons channel on Discord. As Prettier formatting of templates is now deemed stable and the whitespace issues have been resolved should we start encouraging its use for addons in the org?

Just adding this to get the conversation going.

Disadvantages

• It's still early days in its adoption in the wider community
• It's not officially part of the blueprints for Ember apps or addons (Should I create an RFC to kick this off?)
• Additional editor configuration required to format on save, this may be a barrier to entry

Positives

• Similar reasons why we do it for JS, there's a productivity boost from less worrying about formatting and bikeshedding style
• While an contributor's editor mightn't be set up for formatting on save it can be carried out by doing yarn hbs:lint:fix.
• Using Prettier for handlebars for the adopted-ember-addons may help drive adoption

/cc @jelhan @knownasilya @MelSumner @rwjblue

[jelhan]

Thanks a lot for pushing this topic. As already expressed on Discord I fear the additional entry barrier most. In my perspective adopted sddons should be rather conservative in regards to adopting new tools and patterns. But I fully agree that the Ember ecosystem should adopt prettier for handlebars. Having at least an open RFC to add it to default blueprints first, would reduce my concerns.

[MelSumner]

What happens in new Ember apps today?

[jelhan]

What happens in new Ember apps today?

Prettier for Handlebars is not (yet) part of the default blueprints. There isn't even a RFC to add it. Only an issue to consider writing a RFC: emberjs/rfcs#777 Some concerns were raised in that issue if Prettier for Handlebars is good enough already to be used by default for new apps and addon.

[knownasilya]

Can probably finish this up. I believe all issues, beyond stylistic, are fixed.