Added deviceorientationabsolute so absolute positioning with Android Chrome works#25
Open
MrBlenny wants to merge 4 commits intoadtile:masterfrom
Open
Added deviceorientationabsolute so absolute positioning with Android Chrome works#25MrBlenny wants to merge 4 commits intoadtile:masterfrom
deviceorientationabsolute so absolute positioning with Android Chrome works#25MrBlenny wants to merge 4 commits intoadtile:masterfrom
Conversation
|
This breaks support for firefox mobile, with the error DeviceOrientation is not supported. |
FREEZX
reviewed
Nov 12, 2017
| if (event.absolute === true) { | ||
| orientationChangeAbsolute = true; | ||
| } | ||
| if (event.absolute == orientationChangeAbsolute) { |
There was a problem hiding this comment.
Breaks support for non-absolute browsers, like firefox mobile
FREEZX
reviewed
Nov 12, 2017
|
|
||
| if ( sensors.orientation.active ) { | ||
|
|
||
| window.removeEventListener( 'deviceorientationabsolute', handleDeviceOrientationChange, false ); |
There was a problem hiding this comment.
To fix issues with firefox mobile, needs to be like this
if ('ondeviceorientationabsolute' in window) {
window.addEventListener( 'deviceorientationabsolute', handleDeviceOrientationChange, false );
} else if ('ondeviceorientation' in window) {
window.addEventListener( 'deviceorientation', handleDeviceOrientationChange, false );
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
deviceorientationdoes not give absolute aka 'world' positioning on android chrome anymore. This PR fixes that.I'm not sure if this breaks 'game' positioning in any way. This should be tested.