Skip to content

Add withCredentials property#289

Open
mfrro wants to merge 3 commits into
advanced-cropper:vue-nextfrom
mfrro:vue-next
Open

Add withCredentials property#289
mfrro wants to merge 3 commits into
advanced-cropper:vue-nextfrom
mfrro:vue-next

Conversation

@mfrro

@mfrro mfrro commented Oct 28, 2024

Copy link
Copy Markdown

Related Issue: #283

Adds optional withCredentials property, which adds credentials to CORS requests, when set to true.

@binaryfire

Copy link
Copy Markdown

Would be great if we could get this merged.

@ffxsam

ffxsam commented May 27, 2025

Copy link
Copy Markdown

This is an absolutely critical feature. Could someone please merge this? Otherwise, a fork might be in order.

@ffxsam

ffxsam commented Sep 14, 2025

Copy link
Copy Markdown

@Norserium @DerZade One last check before we set up a private package repo and fix this for our own uses.

@Norserium

Copy link
Copy Markdown
Collaborator

@ffxsam, I will investigate this issue soon.

I'm not sure that we need to add the additional prop withCredentials, because you actually can pass 'with-credentials' to crossOrigin prop.

But perhaps, I need to add the passing of this property to getImageData.

@ffxsam

ffxsam commented Sep 14, 2025

Copy link
Copy Markdown

If the intended usage is <Cropper cross-origin="with-credentials" .../>, this isn't documented here:

https://advanced-cropper.github.io/vue-advanced-cropper/components/cropper.html#props

@naflcosta

naflcosta commented Jul 16, 2026

Copy link
Copy Markdown

Hello, what is the status of this PR? I also need it to be able include credentials in the request.. 🙏 Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants