Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #73.
When pushing a message into a
Transportfor sending, we split it into fragments. If the message is zero-sized, no fragments will be made, so theSentMessagewill have aBox<[Option<SentFragment>]>of zero length. Therefore,sent_frags.any(|frag| frag.is_some())will be false, so the message will be immediately dropped before ever being sent. So we will send an empty packet with no message, effectively vanishing this message into the ether, and it will never be acknowledged by the peer.We now say that if we are inserting a message with no fragments, we generate a synthetic empty fragment to "send out", keeping the message alive.