Skip to content

feat: improve keyboard navigation and screen reader accessibility for… #1767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

feat: improve keyboard navigation and screen reader accessibility for… #1767

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
46124db
feat: improve keyboard navigation and screen reader accessibility for…
MARYAMMEHDIZ Oct 31, 2025
d2eb848
fix: Update Choice test to query for input instead of textarea
MARYAMMEHDIZ Nov 6, 2025
d670552
feat: Add openOnFocus to enable keyboard-only dropdown access
MARYAMMEHDIZ Nov 7, 2025
d3c9f52
Merge main into issue/1762
MARYAMMEHDIZ Nov 14, 2025
1615f79
feat: Add explicit role='combobox' for proper VoiceOver recognition
MARYAMMEHDIZ Nov 14, 2025
2c6c673
style: Fix prettier formatting in ChoiceSelectAnswerOptionFields
MARYAMMEHDIZ Nov 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions ...rms-renderer/src/components/FormComponents/ChoiceItems/ChoiceSelectAnswerOptionFields.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,6 @@ function ChoiceSelectAnswerOptionFields(props: ChoiceSelectAnswerOptionFieldsPro
readOnly={readOnly && readOnlyVisualStyle === 'readonly'}
renderInput={(params) => (
<StandardTextField
multiline
textFieldWidth={textFieldWidth}
isTabled={isTabled}
placeholder={entryFormat || displayPrompt}
Expand All @@ -93,7 +92,14 @@ function ChoiceSelectAnswerOptionFields(props: ChoiceSelectAnswerOptionFieldsPro
<ExpressionUpdateFadingIcon fadeIn={expressionUpdated} disabled={readOnly} />
<DisplayUnitText readOnly={readOnly}>{displayUnit}</DisplayUnitText>
</>
)
),
inputProps: {
...params.inputProps,
...(isTabled
? { 'aria-label': qItem.text ?? 'Unnamed choice dropdown' }
: { 'aria-labelledby': `label-${qItem.linkId}` }),
role: 'combobox'
}
}
}}
/>
Expand Down
6 changes: 4 additions & 2 deletions ...s-renderer/src/components/FormComponents/ChoiceItems/ChoiceSelectAnswerValueSetFields.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,6 @@ function ChoiceSelectAnswerValueSetFields(props: ChoiceSelectAnswerValueSetField
readOnly={readOnly && readOnlyVisualStyle === 'readonly'}
renderInput={(params) => (
<StandardTextField
multiline
textFieldWidth={textFieldWidth}
isTabled={isTabled}
placeholder={entryFormat || displayPrompt}
Expand All @@ -103,7 +102,10 @@ function ChoiceSelectAnswerValueSetFields(props: ChoiceSelectAnswerValueSetField
),
inputProps: {
...params.inputProps,
'aria-label': qItem.text ?? 'Unnamed choice dropdown'
...(isTabled
? { 'aria-label': qItem.text ?? 'Unnamed choice dropdown' }
: { 'aria-labelledby': `label-${qItem.linkId}` }),
role: 'combobox'
}
}
}}
Expand Down
2 changes: 1 addition & 1 deletion packages/smart-forms-renderer/src/stories/itemTypes/Choice.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ export const ChoiceAnswerOptionBasic: Story = createStory({
expect(resultAfterClear).toHaveLength(0);

const elementAfterClear = await findByLinkIdOrLabel(canvasElement, aoTargetLinkId);
const input = elementAfterClear.querySelector('textarea');
const input = elementAfterClear.querySelector('input');
expect(input?.value).toBe('');
}
}) as Story;
Expand Down
Loading