Skip to content

update language in banner #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 28, 2020
Merged

update language in banner #57

merged 1 commit into from
Mar 28, 2020

Conversation

aeon1234
Copy link
Contributor

@aeon1234 aeon1234 commented Oct 23, 2018

new PR after squash issues in #52

I created this PR after my comment got positive feedback in #2

I renamed Features heading from A lightweight CryptoNote digital currency to Features, because it will be basically same as in banner. if you have any better idea, please let me know.

paging
@sci-comp
@shigutso
@BigslimVdub
@thriftyMinnow
@camthegeek

UPDATE 2020-03-26:

  • rebased
  • used google translate for non-English languages

preview
aeon1
aeon2

@BigslimVdub
Copy link
Contributor

Looks good!

@BigslimVdub
Copy link
Contributor

I suppose this isn't applicable now with all the translations done. Are you still interested in this change? It looks like nobody ever commented on it after the initial conversation on the issue.

@aeon1234
Copy link
Contributor Author

aeon1234 commented Jun 28, 2019

I suppose this isn't applicable now with all the translations done.

While this change will not be in current language files, I don't hope this means we have to generally stagnate now. and for me it's also no reason not to change it. most (maybe all) people interested in aeon at this time will understand it.

Are you still interested in this change?

Yes, otherwise I had closed this PR. I still think that current slogan is not helping to maybe even harmful. But I'm not bound to this particular suggestion and open for other ideas and feedback.

It looks like nobody ever commented on it after the initial conversation on the issue.

There was very positive comments / likes (on #2 and #52). This PR was only created because of squash issues in #52, so for me it looked like this is the reason why nobody commented / liked this PR again.


There may exist reasons why it's not merged, but I cannot understand why one of these two points never happened after over 8 months:

  • this PR got merged
  • this PR got commented by smooth, why it's not getting merged

@aeon1234 aeon1234 closed this Mar 26, 2020
@aeon1234 aeon1234 reopened this Mar 26, 2020
@aeonix aeonix merged commit f573c9e into aeonix:master Mar 28, 2020
@aeon1234 aeon1234 deleted the language branch April 12, 2020 05:44
@aeon1234 aeon1234 mentioned this pull request Jan 24, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants