Skip to content

Fix broken links #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix broken links #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion source/dapp-development/index.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ Aergo also offers a development toolchain that includes package management, `Aer
Infrastructure
--------------

Aergo is currently available as a `public testnet <../using-testnet/index.html>`_ and separate private installations.
Aergo is currently available as a `public testnet <../using-network/connecting.rst#testnet>`_ and separate private installations.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The correct is https://docs.aergo.io/en/latest/using-network/connecting.html#testnet
html instead of rst

In the future, a network of blockchains can be orchestrated using Aergo Horde. Aergo Hub will offer an easy configuration and monitoring interface.
With these features, developers will not have to worry about the deployment of their applications.

2 changes: 1 addition & 1 deletion source/running-node/configure-network.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ Generate BP accounts and keys

You can use any machine (e.g. your own local machine) for this.

Start by installing `aergocli <../tools/aergocli.html>`__ if you haven't already.
Start by installing `aergocli <../tools/aergocli.rst>`__ if you haven't already.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same, and for many other changes on this PR


**Generate accounts**

Expand Down
2 changes: 1 addition & 1 deletion source/specs/consensus.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ Staking & Voting
user wanting to vote must stake their tokens since the voting power is
weighted by the number of staked tokens, as remarked above.

All of these requests are performed via a `transaction <./transactions.html#governance-type>`_.
All of these requests are performed via a `transaction <./transactions.rst#governance_type>`_.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be /specs/transactions.html#governance-type-1
Then there is no need to add new anchor

Therefore, all proccesses are transparently recorded in the blockchain
and can be verified by anyone.

Expand Down
2 changes: 1 addition & 1 deletion source/specs/fees.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ Transaction Fees
The Aergo protocol includes transaction fees that need to be paid
according to the configuration of the network.

Versions prior to 2.0 (`see 1.3 docs <https://docs.aergo.io/en/1.3/specs/fees.html>`_)
Versions prior to 2.0 (`see 1.3 docs <https://aergo.readthedocs.io/en/1.3/specs/fees.html>`_)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should be docs.aergo.io
if the link is not working, then the correct must be found

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears that only links to /latest/ are working
Links to direct versions are not working, for some reason
We will need to check that

included a simplified transaction fee scheme, taking into account payload and state database usage size.

This is not fair because it does not consider the actual execution time and resource usage of the transaction.
Expand Down
4 changes: 2 additions & 2 deletions source/specs/names.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ In case of normal accounts, these two values will be identical, but they differ
Creating and updating names
---------------------------

The easiest way to create and update names is the `aergocli <../tools/aergocli.html>`_.
The easiest way to create and update names is the `aergocli <../tools/aergocli.rst>`_.

Registering and updating names requires spending a cetrain amount of aergo determined by the DAO vote "nameprice".

Expand Down Expand Up @@ -56,7 +56,7 @@ Technical details
-----------------

Names are stored in the state of the special account :code:`aergo.name`. They are created and updated using special governance transactions.
Refer to `transaction types <transaction-types.html>`_ for the technical specification of these actions.
Refer to `transaction types <transactions.rst#transaction_types>`_ for the technical specification of these actions.
Copy link
Member

@kroggen kroggen Dec 6, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be /specs/transactions.html#transaction-types
And then there is no need to add a new anchor

Governance transactions don't require any fee, but the name system requires an amount of aergo to be included in the transaction.
This amount is determined by the DAO vote "nameprice". You can check the current name price in the ChainInfo. When using the CLI, the price is automatically set.

Expand Down
4 changes: 4 additions & 0 deletions source/specs/transactions.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,8 @@ Payload
A payload can be any kind of binary data, but is most often used with JSON strings for
`smart contract calls <contracts.html>`__.

.. transaction_types:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As said above, this is not required


Transaction types
-----------------

Expand All @@ -47,6 +49,8 @@ Normal type (0)
Normal transactions are used to transfer tokens and calling smart contracts.
Since version 2.0, there are more precise transaction types that should be used instead.

.. governance_type:

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neither this

Governance type (1)
^^^^^^^^^^^^^^^^^^^

Expand Down
6 changes: 4 additions & 2 deletions source/using-network/connecting.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,9 @@ Use `mainnet-api.aergo.io` and the default port 7845 to connect to a public GRPC

docker run --rm aergo/tools aergocli -H mainnet-api.aergo.io blockchain

A public blockchain explorer is available at `mainnet.aergoscan.io <https://alpha.aergoscan.io>`_.
A public blockchain explorer is available at `mainnet.aergoscan.io <https://mainnet.aergoscan.io>`_.

.. testnet:

Testnet
-------
Expand All @@ -21,7 +23,7 @@ Use `testnet-api.aergo.io` and the default port 7845 to connect to a public GRPC

docker run --rm aergo/tools aergocli -H testnet-api.aergo.io blockchain

A public blockchain explorer is available at `testnet.aergoscan.io <https://alpha.aergoscan.io>`_.
A public blockchain explorer is available at `testnet.aergoscan.io <https://testnet.aergoscan.io>`_.

Alpha
-----
Expand Down