Adapted plotting functions to work without cistopic object. #205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeppeDeWinter
commented
Mar 13, 2025
Collaborator
Author
SeppeDeWinter
left a comment
SeppeDeWinter
left a comment
There was a problem hiding this comment.
@DadaAb Thanks for the changes.
Looks good, one small comment.
src/pycisTopic/clust_vis.py
Outdated
| target: str = "cell", | ||
| k: int = 10, | ||
| res: list[float] | None = None, | ||
| res: list[float] = [0.6], |
Collaborator
Author
There was a problem hiding this comment.
Using a list as default can cause unexpected results
See: https://docs.python-guide.org/writing/gotchas/
Better to use
def find_clusters(
...,
res: list[float] | None = None,
...
)and in the function body
if res is None:
res = [0.6]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.