Skip to content

Add support for equirect layer #5710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

vincentfretin
Copy link
Contributor

Description:

Add support for equirect layer, mono and stereo 180 and 360 videos and equirectangular image.

Remaining to do:

Changes proposed:

  • Add 'mono-equirect', 'stereo-left-right-equirect', 'stereo-top-bottom-equirect' types
  • Add is180 property

@vincentfretin
Copy link
Contributor Author

I see @danrossi also experimented with this on a threejs example in mrdoob/three.js#31019
I'll probably continue working on this on the weekend.

@vincentfretin
Copy link
Contributor Author

For stereo-top-bottom image, Meta browser version 38.2.0.13.53.728503412 and OS version 76.1024 still wrongly shows the top to the right eye.
For stereo-top-bottom video with XRMediaBinding.createEquirectLayer, the top is correctly on the left eye.
See issue immersive-web/webxr-samples#132 (comment)

@vincentfretin
Copy link
Contributor Author

The stereo-top-bottom image on a layer should be fixed on the next Meta browser release.

I did another branch https://github.com/vincentfretin/aframe/tree/layer-equirect-wip with a quick and dirty implementation of using the stereo component and some code that I previously had in my project to switch between mono and stereo the spheres uvs and using a single stereo-top-bottom image, that works but I needs to refactor that to keep only the layer component.

@vincentfretin
Copy link
Contributor Author

The stereo-top-bottom image on a layer should be fixed on the next Meta browser release.

It's working correctly on Meta browser 38.4!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant