-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ refactor ] Symmetry of Bijection
as a consequence of properties of a given Surjective
function
#2583
base: master
Are you sure you want to change the base?
Conversation
@JacquesCarette which of this and #2569 do you prefer? We should (probably) only merge one of them... |
I'll only return to the merge conflicts once we choose between this v3.0 version, and the clunkier v2.3 #2569 |
There's a lot in common between them, so I'm having a hard time spotting exactly where the differences are? |
The main difference is that
This was the one that made me seriously think we should simply leapfrog to a full, breaking, v3.0... and I am still considering withdrawing the v2.3 one as too compromised to be worth the effort? Hence the request for comment. |
I've downgraded/closed the earlier #2569 in favour of this one. Will fix the merge conflicts, and tidy up the comments to sort out the discussion of congruence. DONE. |
Alternative version of #2569 which dispenses with much of the deprecation cruft, in favour of badging this as a
bug
fix.No separate
module Section
added, in favour of folding everything into the definitions ofFunction.Structures.IsBijection
andFunction.Bundles.Bijection
.NB. there may now be some further redundancy that could be pruned out: manifest fields, or
Properties
?