Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Set to Type #397

Merged
merged 4 commits into from
Mar 10, 2025

Conversation

HeinrichApfelmus
Copy link
Contributor

This pull request introduces the name Type instead of the name Set for all types that are transpiled to Haskell. This change has two motivations:

  • Be more consistent with nomenclature from Haskell, where the canonical name for types is Type.
  • Avoid the name clash with Set from the containers package.

Using Type instead of Set removes a small, yet pervasive stumbling block for people who know Haskell and want to learn Agda2hs. In principle, people can learn the difference, but in this case, I believe that this is learning effort not well-spent.

(In a future change, it may make sense to introduce Prop in addition to Type in order to better distinguish between propositions about Haskell and types in Haskell — while every Haskell type can be transpiled from a Type, the converse is not true. But that discussion is out of scope for this pull request.)

@HeinrichApfelmus HeinrichApfelmus force-pushed the HeinrichApfelmus/set-to-type branch 2 times, most recently from 6d0667d to fecee0b Compare February 1, 2025 12:57
Copy link
Contributor

@omelkonian omelkonian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a couple of minor omissions.

@HeinrichApfelmus HeinrichApfelmus force-pushed the HeinrichApfelmus/set-to-type branch from fecee0b to 625c3e7 Compare March 8, 2025 10:10
@HeinrichApfelmus
Copy link
Contributor Author

Thanks for your review!

I have just noticed that the documentation still mentioned Set instead of Type; I have changed that as well and also added a small note for Agda users that mentions the renaming.

@omelkonian could you take another look? If you're happy, could you also merge the pull request? — I do not have sufficient permissions to merge anything, this pull request is coming from a fork.

@omelkonian omelkonian merged commit aed00e3 into agda:master Mar 10, 2025
7 checks passed
@HeinrichApfelmus HeinrichApfelmus deleted the HeinrichApfelmus/set-to-type branch March 10, 2025 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants