Fix null reference error when sending custom welcome message#1161
Open
PaoloC68 wants to merge 1 commit intoagent0ai:developmentfrom
Open
Fix null reference error when sending custom welcome message#1161PaoloC68 wants to merge 1 commit intoagent0ai:developmentfrom
PaoloC68 wants to merge 1 commit intoagent0ai:developmentfrom
Conversation
Add optional chaining on selectedContext.running in webui/index.js. When a custom welcome message is configured, auto-send triggers before selectedContext is initialized, causing 'Cannot read properties of undefined (reading running)'. This matches the existing pattern used in input-store.js.
PaoloC68
force-pushed
the
fix/welcome-message-null-check
branch
from
878be5e to
e81cbfb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1164
Summary
Fixes
Cannot read properties of undefined (reading 'running')error that occurs when a custom welcome message is configured. The auto-send triggers beforeselectedContextis initialized in the Alpine.js store.Change
webui/index.jsline 60: Add optional chaining operator (?.) onselectedContext.running.This matches the existing pattern already used in
webui/js/input-store.jsline 15:Testing
One-line defensive fix. The optional chaining safely returns
undefined(falsy) whenselectedContextis null, allowing the send to proceed normally once the context initializes.