Fix PWA installability and update contributor docs links#1261
Open
EstevesAndre wants to merge 3 commits intoagent0ai:developmentfrom
Open
Fix PWA installability and update contributor docs links#1261EstevesAndre wants to merge 3 commits intoagent0ai:developmentfrom
EstevesAndre wants to merge 3 commits intoagent0ai:developmentfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR restores working PWA behavior and fixes stale contributor documentation links.
Target branch:
developmentSource branch:
fix/pwa-service-worker-scopeProblem
PWA support was present in changelog/release notes, but installability/runtime behavior was broken in practice.
Contributor docs also had outdated links and an incomplete local dependency step.
Root Causes
js/sw.js(scope under/js/instead of/)webui/js/sw.jswas empty, so no real SW behavior existeddevelopment.md,websocket-infrastructure.md)requirements2.txt(needed for override pins used in Docker)Changes
PWA fixes
webui/sw.jswebui/js/sw.jsimports/sw.jswebui/public/icon-192.pngwebui/public/icon-512.pngwebui/public/apple-touch-icon.pngwebui/js/manifest.jsonwithid,scope, and PNG iconsDocs fixes
docs/guides/contribution.mddocs/developer/architecture.mddocs/setup/dev-setup.mdpip install -r requirements2.txtso local development matches Docker dependency behavior.
Validation
python3 -m pytest tests/test_pwa_wiring.pyNotes
This PR fixes repo-side PWA and docs issues.
Live installability on VPS still depends on secure origin/browser policy (
https://orlocalhost).