Fix: Auto-correct args/Args to tool_args in tool calls#866
Closed
Krashnicov wants to merge 2 commits intoagent0ai:developmentfrom
Closed
Fix: Auto-correct args/Args to tool_args in tool calls#866Krashnicov wants to merge 2 commits intoagent0ai:developmentfrom
Krashnicov wants to merge 2 commits intoagent0ai:developmentfrom
Conversation
Follows up on PR agent0ai#788 (Subordinate agents settings override). When subordinate agents have a settings.json in their profile directory, the profile was getting reset to 'agent0' instead of preserving the intended profile. Root cause: initialize_agent() creates a new config with default profile, and while memory_subdir was preserved, the profile was not. Fix: Apply the same preservation pattern used for memory_subdir to profile.
Fixes issue where models occasionally use 'args' or 'Args' (capitalized) instead of 'tool_args' in tool call JSON structure due to cognitive interference from API conventions. Changes: - Add auto-correction in json_parse_dirty() to transparently rename 'args' or 'Args' to 'tool_args' when 'tool_args' is missing - Add negative examples to communication prompt showing incorrect plain-text output vs correct JSON format This prevents tool execution failures without breaking existing code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue where models use args/Args instead of tool_args