Preserve metadata on elicitation property schemas - #113
Merged
Ololoshechkin merged 1 commit intoJul 29, 2026
Merged
Conversation
Typed elicitation property schemas now implement AcpWithMeta so clients can consume provider-specific schema annotations without falling back to string heuristics. The serialization test covers round-tripping a Codex-style custom-answer marker and the API dump is updated.
Ololoshechkin
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
AIR/Codex needs to identify custom-answer elicitation fields from provider metadata instead of guessing from field names or descriptions. The typed Kotlin schema model currently drops
_metaon elicitation properties, so clients cannot consume those provider-specific annotations after deserialization.What changed
ElicitationPropertySchemaimplementAcpWithMeta._meta: JsonElement?to each typed elicitation property variant so unknown provider annotations survive JSON encode/decode.Tests
schema property preserves metatoElicitationSerializationTest._metaobject and deserializing it back on the typedStringProperty.JAVA_HOME=$(/usr/libexec/java_home -v 21) ./gradlew :acp-model:jvmTest --tests com.agentclientprotocol.model.ElicitationSerializationTest :acp-model:apiCheck