Skip to content

Add support for non-camelCase function names #813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lyuboraykov wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add support for non-camelCase function names #813

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7bbee06
Add support for non-camelCase function names
Jan 24, 2024
a624468
revert unintentional formatting
Jan 24, 2024
f0bd401
just use the built-in function
Jan 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/serverless-sns-sqs-lambda.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,7 +345,7 @@ Usage
`);
}

const funcNamePascalCase = pascalCase(funcName);
const funcNamePascalCase = this.serverless.providers.aws.naming.getNormalizedFunctionName(funcName);
Copy link
Member

@dspasojevic dspasojevic Jan 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

polish: in addition to @NoxHarmonium's more substantive feedback, it would be great to rename the variable to reflect that it will be config-driven normalisation.

Suggested change
const funcNamePascalCase = this.serverless.providers.aws.naming.getNormalizedFunctionName(funcName);
const funcNameNormalised = SOME_CONFIG_CHECK ? this.serverless.providers.aws.naming.getNormalizedFunctionName(funcName) : pascalCase(funcName);

return {
...config,
name: config.name,
Expand Down